Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Configurable reboot command #1274

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

mike-sul
Copy link
Collaborator

This is replacement for #1148 to trigger the gitlab CI.

This patch mainly aims to add a graceful way to reboot the system by
executing a user preferred reboot command rather than calling reboot
system call. The reboot command could be set in 'bootloader' section of
a config file, it defaults to be '/sbin/reboot'.

Signed-off-by: Mykhaylo Sul [email protected]

This patch mainly aims to add a graceful way to reboot the system by
executing a user preferred reboot command rather than calling reboot
system call. The reboot command could be set in 'bootloader' section of
a config file, it defaults to be '/sbin/reboot'.

Signed-off-by: Mykhaylo Sul <[email protected]>
@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #1274 into master will increase coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   79.61%   79.73%   +0.12%     
==========================================
  Files         173      173              
  Lines       10315    10320       +5     
==========================================
+ Hits         8212     8229      +17     
+ Misses       2103     2091      -12
Impacted Files Coverage Δ
src/libaktualizr/bootloader/bootloader.h 100% <ø> (ø) ⬆️
src/libaktualizr/bootloader/bootloader_config.h 100% <ø> (ø) ⬆️
src/libaktualizr/bootloader/bootloader_config.cc 90% <100%> (+0.71%) ⬆️
src/libaktualizr/bootloader/bootloader.cc 49.23% <14.28%> (-0.77%) ⬇️
src/libaktualizr-posix/ipuptanesecondary.cc 82.66% <0%> (-4%) ⬇️
src/aktualizr_primary/secondary.cc 82.89% <0%> (-1.32%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 75.89% <0%> (-0.13%) ⬇️
src/libaktualizr/primary/sotauptaneclient.cc 92.12% <0%> (+0.6%) ⬆️
src/libaktualizr/storage/sql_utils.h 85.91% <0%> (+1.4%) ⬆️
src/libaktualizr/package_manager/ostreemanager.cc 77.96% <0%> (+1.69%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3b131...056b80d. Read the comment docs.

@pattivacek pattivacek merged commit 76a5a61 into master Jul 31, 2019
@pattivacek pattivacek deleted the feat/reboot/configurable-reboot-command branch July 31, 2019 16:01
pattivacek added a commit that referenced this pull request Sep 16, 2020
It was lost during the docs transition last year. See
056b80d or
#1274 for the
original feature.

Signed-off-by: Patrick Vacek <[email protected]>
pattivacek added a commit that referenced this pull request Sep 16, 2020
It was lost during the docs transition last year. See
056b80d or
#1274 for the
original feature.

Signed-off-by: Patrick Vacek <[email protected]>
aodukha pushed a commit that referenced this pull request Oct 27, 2020
It was lost during the docs transition last year. See
056b80d or
#1274 for the
original feature.

Signed-off-by: Patrick Vacek <[email protected]>
aodukha added a commit that referenced this pull request Oct 27, 2020
Signed-off-by: Anatoliy Odukha <[email protected]>

Restore reboot_command to aktualizr config doc.

It was lost during the docs transition last year. See
056b80d or
#1274 for the
original feature.

Signed-off-by: Patrick Vacek <[email protected]>

add "Find the unsigned Root and Targets metadata" page to docs

Signed-off-by: Danylo Tereshchenko <[email protected]>

Add a link

List all of the garage-sign-related instructions on the reference page.

Relates-to: OTA-5253

Signed-off-by: Halyna Dumych <[email protected]>

fixed PR review comments

Signed-off-by: Anatoliy Odukha <[email protected]>
aodukha added a commit that referenced this pull request Oct 27, 2020
Signed-off-by: Anatoliy Odukha <[email protected]>

Restore reboot_command to aktualizr config doc.

It was lost during the docs transition last year. See
056b80d or
#1274 for the
original feature.

Signed-off-by: Patrick Vacek <[email protected]>

add "Find the unsigned Root and Targets metadata" page to docs

Signed-off-by: Danylo Tereshchenko <[email protected]>

Add a link

List all of the garage-sign-related instructions on the reference page.

Relates-to: OTA-5253

Signed-off-by: Halyna Dumych <[email protected]>

fixed PR review comments

Signed-off-by: Anatoliy Odukha <[email protected]>
aodukha added a commit that referenced this pull request Oct 27, 2020
Signed-off-by: Anatoliy Odukha <[email protected]>

Restore reboot_command to aktualizr config doc.

It was lost during the docs transition last year. See
056b80d or
#1274 for the
original feature.

Signed-off-by: Patrick Vacek <[email protected]>

add "Find the unsigned Root and Targets metadata" page to docs

Signed-off-by: Danylo Tereshchenko <[email protected]>

Add a link

List all of the garage-sign-related instructions on the reference page.

Relates-to: OTA-5253

Signed-off-by: Halyna Dumych <[email protected]>

fixed PR review comments

Signed-off-by: Anatoliy Odukha <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants