Some more lintian fixes #1242
Some more lintian fixes #1242
Conversation
| if [ "$1" = "purge" ]; then | ||
| if [ -x "/usr/bin/deb-systemd-helper" ]; then | ||
| deb-systemd-helper purge 'aktualizr.service' >/dev/null || true | ||
| deb-systemd-helper unmask 'aktualizr.service' >/dev/null || true |
There was a problem hiding this comment.
Is this all just to remove it if it is still running? We're no longer running it as a daemon anymore, right?
There was a problem hiding this comment.
Yes that's right. I've actually been using the network-manager debian package as a model. They use an automated debian tool to generate these steps actually but I think it would be impractical to do that through CMake/CPack which is quite rudimentary.
The intent is just to add testutilities to the list Also remove the redundant gcov link, already done in CodeCoverage.cmake. Signed-off-by: Laurent Bonnans <[email protected]>
And use deb-systemd-helper instead of systemctl, as recommended by lintian Signed-off-by: Laurent Bonnans <[email protected]>
It's unused right now Signed-off-by: Laurent Bonnans <[email protected]>
* provide a long description * `set -e` in maintainer scripts Signed-off-by: Laurent Bonnans <[email protected]>
In case the package was removed before (and systemd service masked) Signed-off-by: Laurent Bonnans <[email protected]>
lbonn
force-pushed
the
fix/OTA-3099/deb-no-systemctl
branch
from
8b94dbd to
7a43daa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
+ Coverage 79.27% 79.53% +0.26%
==========================================
Files 170 170
Lines 10140 10140
==========================================
+ Hits 8038 8065 +27
+ Misses 2102 2075 -27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I haven't tested but looks fine. Once we make a new release with this change we should double-check with QA (FYI @Raigi) that everything looks okay and works as expected for their tools/tests.
No description provided.