This repository has been archived by the owner on May 21, 2024. It is now read-only.
Refact/ota 2487/ipsecondaries initialization #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mike-sul
commented
May 1, 2019
mike-sul
commented
- Add ability to specify params that are common across secondaries of the same type (connection wait timeout);
- Primary waits for a connection from Secondary if it fails to connect to it. Secondary tries to connect to Primary at a startup time.
Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
refact/OTA-2487/ipsecondaries-initialization
branch
6 times, most recently
from
e8e7bf2 to
874391a
Compare
pattivacek
reviewed
May 2, 2019
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| namespace Primary { | |||
|
|
|||
| const char* const IPSecondariesConfig::Type = "IP"; | |||
| const char* const IPSecondaryConfig::Type = "ip"; | |||
There was a problem hiding this comment.
Seems slightly odd to have two constants that are seemingly the same except for subtle differences in count and capitalization. Are these both really necessary?
There was a problem hiding this comment.
no, they aren't, I've removed IPSecondaryConfig::Type
| @@ -10,20 +10,30 @@ | |||
|
|
|||
| namespace Uptane { | |||
|
|
|||
| std::shared_ptr<Uptane::SecondaryInterface> IpUptaneSecondary::create(const std::string& address, unsigned short port) { | |||
| std::pair<bool, std::shared_ptr<Uptane::SecondaryInterface>> IpUptaneSecondary::connectAndcreate( | |||
There was a problem hiding this comment.
Pretty insignificant, but we generally like camelCase, so this should be "connectAndCreate".
mike-sul
force-pushed
the
refact/OTA-2487/ipsecondaries-initialization
branch
from
874391a to
3aa0366
Compare
…ct to it Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
refact/OTA-2487/ipsecondaries-initialization
branch
from
3aa0366 to
a7b825d
Compare
pattivacek
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.