This repository has been archived by the owner on May 21, 2024. It is now read-only.
Doc/misc #1164
Merged
Doc/misc #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
requested review from
lbonn,
tkfu,
eu-siemann,
merltron,
xaviergully and
mike-sul
"Developing and debugging with an OpenEmbedded system" does not need to be in the top-level README. It was also the only image in that doc, which was kind of weird. Signed-off-by: Patrick Vacek <[email protected]>
Signed-off-by: Patrick Vacek <[email protected]>
Signed-off-by: Patrick Vacek <[email protected]>
The old format was not user-friendly. Now it should be easier to cut-and-paste the parts that you need directly into a CLI. Signed-off-by: Patrick Vacek <[email protected]>
Some fairly important details were missing or slightly inaccurate. Signed-off-by: Patrick Vacek <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 77.89% 77.93% +0.03%
==========================================
Files 170 170
Lines 10010 10010
==========================================
+ Hits 7797 7801 +4
+ Misses 2213 2209 -4
Continue to review full report at Codecov.
|
Signed-off-by: Patrick Vacek <[email protected]>
mike-sul
approved these changes
Apr 4, 2019
eu-siemann
approved these changes
Apr 5, 2019
lbonn
reviewed
Apr 9, 2019
| Additional packages are used for non-essential components: | ||
|
|
||
| * To build the test suite, you will need `python3-dev python3-openssl python3-venv sqlite3 valgrind`. | ||
| * To run the lintint tools, you will need `clang clang-format-6.0 clang-tidy-6.0`. |
There was a problem hiding this comment.
Oops. If you're working on the /etc installation issue, do you mind including a fix for this, too?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to encourage you to do a once-over of our front-facing README with these changes and then consider if anything obvious is missing, wrong, or poorly worded. Hopefully this is at least better than what was there before!