This repository has been archived by the owner on May 21, 2024. It is now read-only.
Get rid of running modes. #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aktualizr still has an input parameter (--run-mode) that does the same thing, but this is no longer wired directly into libaktualizr; it exists purely in the wrapper outside it. This should be much cleaner and simpler to use. Note that once upon a time I advocated for all aktualizr commandline options to be also represented in the config. I no longer believe this to be a good idea for things that only matter outside of libaktualizr. An internal "run mode" for libaktualizr does not make sense. It should be driven by the code outside of the API. Signed-off-by: Patrick Vacek <[email protected]>
If we have to use FAIL(), we should at least provide an explanation to the user running the test. Signed-off-by: Patrick Vacek <[email protected]>
Testing that nothing is downloaded without calling Download() explicitly is already covered by the other download tests. Testing that UptaneCycle does what we expect when no updates are found is perhaps slightly more interesting, however. Signed-off-by: Patrick Vacek <[email protected]>
|
Great, thanks! Some instances left (bad doc and failing tests): |
Sorry, "running-mode" was always slightly weird to me. Signed-off-by: Patrick Vacek <[email protected]>
On it, I noticed at the same time you did! |
lbonn
approved these changes
Dec 18, 2018
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 82.21% 82.25% +0.03%
==========================================
Files 196 196
Lines 13825 13787 -38
==========================================
- Hits 11366 11340 -26
+ Misses 2459 2447 -12
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aktualizr still has an input parameter (--run-mode) that does the same thing, but this is no longer wired directly into libaktualizr; it exists purely in the wrapper outside it. This should be much cleaner and simpler to use.
Note that once upon a time I advocated for all aktualizr commandline options to be also represented in the config. I no longer believe this to be a good idea for things that only matter outside of libaktualizr. An internal "run mode" for libaktualizr does not make sense. It should be driven by the code outside of the API.