Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Only run aktualizr-repo tests with ed25519 #1038

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Dec 18, 2018

They used to be run with all key types, including big RSA.

This was our longest running test, despite testing one of our less critical piece of code. Let's just use the fastest key type we have.

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #1038 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
- Coverage   82.34%   82.25%   -0.09%     
==========================================
  Files         196      196              
  Lines       13858    13853       -5     
==========================================
- Hits        11411    11395      -16     
- Misses       2447     2458      +11
Impacted Files Coverage Δ
src/aktualizr_repo/repo_test.cc 95.09% <100%> (-0.23%) ⬇️
src/libaktualizr/utilities/types.h 76.92% <0%> (-10.26%) ⬇️
src/libaktualizr/crypto/crypto.cc 86% <0%> (-2.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a1ce0...e77dd0e. Read the comment docs.

@pattivacek
Copy link
Collaborator

Nice:
87/112 Test #91: test_aktualizr_repo ................................. Passed 7.77 sec

They used to be run with all key types, including big RSA.

This was our longest running test, despite testing one of our less
critical piece of code. Let's just use the fastest key type we have.

Signed-off-by: Laurent Bonnans <[email protected]>
@lbonn lbonn force-pushed the fix/slow-repo-test branch from a2fc207 to e77dd0e Compare December 18, 2018 10:15
Copy link
Contributor

@patriotyk patriotyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this issue. But I have an idea to run 'generate_repo' test with all key types and all rest with default. This could be the best compromise between speed and coverage.

@lbonn
Copy link
Contributor Author

lbonn commented Dec 18, 2018

@patriotyk no problem, feel free to submit enhancements in other PRs if we can have better tests with a reasonable running time.

I went for the easiest way because the running time really got out of hand and was causing timeouts on Travis.

@lbonn lbonn merged commit b1c3e87 into master Dec 18, 2018
@lbonn lbonn deleted the fix/slow-repo-test branch December 18, 2018 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants