Test for device installation result from ecus

A bit rough, to refactor Signed-off-by: Laurent Bonnans <[email protected]>
advancedtelematic · Mar 20, 2019 · abcfec6 · abcfec6
1 parent 536d5bc
commit abcfec6
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 0 deletions.
diff --git a/src/libaktualizr/primary/aktualizr.h b/src/libaktualizr/primary/aktualizr.h
@@ -187,6 +187,7 @@ class Aktualizr {
 
  private:
   FRIEND_TEST(Aktualizr, FullNoUpdates);
+  FRIEND_TEST(Aktualizr, DeviceInstallationResult);
   FRIEND_TEST(Aktualizr, FullWithUpdates);
   FRIEND_TEST(Aktualizr, FullWithUpdatesNeedReboot);
   FRIEND_TEST(Aktualizr, AutoRebootAfterUpdate);

diff --git a/src/libaktualizr/primary/aktualizr_test.cc b/src/libaktualizr/primary/aktualizr_test.cc
@@ -103,6 +103,61 @@ TEST(Aktualizr, FullNoUpdates) {
   verifyNothingInstalled(aktualizr.uptane_client_->AssembleManifest());
 }
 
+/*
+ * Unit test for device installation result computation
+ */
+TEST(Aktualizr, DeviceInstallationResult) {
+  TemporaryDirectory temp_dir;
+  auto http = std::make_shared<HttpFake>(temp_dir.Path());
+  Config conf = UptaneTestCommon::makeTestConfig(temp_dir, http->tls_server);
+
+  auto storage = INvStorage::newStorage(conf.storage);
+
+  EcuSerials serials{
+      {Uptane::EcuSerial("primary"), Uptane::HardwareIdentifier("primary_hw")},
+      {Uptane::EcuSerial("ecuserial3"), Uptane::HardwareIdentifier("hw_id3")},
+  };
+  storage->storeEcuSerials(serials);
+
+  Aktualizr aktualizr(conf, storage, http);
+
+  // TODO: was stolen from other test, refactor
+  Uptane::SecondaryConfig ecu_config;
+  ecu_config.secondary_type = Uptane::SecondaryType::kVirtual;
+  ecu_config.partial_verifying = false;
+  ecu_config.full_client_dir = temp_dir.Path();
+  ecu_config.ecu_serial = "ecuserial3";
+  ecu_config.ecu_hardware_id = "hw_id3";
+  ecu_config.ecu_private_key = "sec.priv";
+  ecu_config.ecu_public_key = "sec.pub";
+  ecu_config.firmware_path = temp_dir / "firmware.txt";
+  ecu_config.target_name_path = temp_dir / "firmware_name.txt";
+  ecu_config.metadata_path = temp_dir / "secondary_metadata";
+
+  aktualizr.AddSecondary(Uptane::SecondaryFactory::makeSecondary(ecu_config));
+
+  aktualizr.Initialize();
+
+  storage->saveEcuInstallationResult(Uptane::EcuSerial("ecuserial3"), data::InstallationResult());
+  storage->saveEcuInstallationResult(Uptane::EcuSerial("primary"), data::InstallationResult());
+  storage->saveEcuInstallationResult(Uptane::EcuSerial("primary"),
+                                     data::InstallationResult(data::ResultCode::Numeric::kInstallFailed, ""));
+
+  data::InstallationResult result;
+  aktualizr.uptane_client_->computeDeviceInstallationResult(&result, "correlation_id");
+  auto res_json = result.toJson();
+  EXPECT_EQ(res_json["code"].asString(), "primary_hw:INSTALL_FAILED");
+  EXPECT_EQ(res_json["success"], false);
+
+  storage->saveEcuInstallationResult(
+      Uptane::EcuSerial("ecuserial3"),
+      data::InstallationResult(data::ResultCode(data::ResultCode::Numeric::kInstallFailed, "SECOND_FAIL"), ""));
+  aktualizr.uptane_client_->computeDeviceInstallationResult(&result, "correlation_id");
+  res_json = result.toJson();
+  EXPECT_EQ(res_json["code"].asString(), "primary_hw:INSTALL_FAILED|hw_id3:SECOND_FAIL");
+  EXPECT_EQ(res_json["success"], false);
+}
+
 /*
  * Add secondaries via API
  */

diff --git a/src/libaktualizr/primary/sotauptaneclient.h b/src/libaktualizr/primary/sotauptaneclient.h
@@ -62,6 +62,7 @@ class SotaUptaneClient {
 
  private:
   FRIEND_TEST(Aktualizr, FullNoUpdates);
+  FRIEND_TEST(Aktualizr, DeviceInstallationResult);
   FRIEND_TEST(Aktualizr, FullMultipleSecondaries);
   FRIEND_TEST(Aktualizr, CheckNoUpdates);
   FRIEND_TEST(Aktualizr, DownloadWithUpdates);