Test for autoclean aktualizr callback

Signed-off-by: Laurent Bonnans <[email protected]>

src/libaktualizr/primary/aktualizr_test.cc

@@ -12,6 +12,7 @@
 #include "config/config.h"
 #include "httpfake.h"
 #include "primary/aktualizr.h"
+#include "primary/aktualizr_helpers.h"
 #include "primary/events.h"
 #include "primary/sotauptaneclient.h"
 #include "uptane_test_common.h"
@@ -1362,6 +1363,62 @@ TEST(Aktualizr, DownloadListRemove) {
   EXPECT_EQ(targets.size(), 0);
 }
 
+TEST(Aktualizr, TargetAutoremove) {
+  TemporaryDirectory temp_dir;
+  const boost::filesystem::path local_metadir = temp_dir / "metadir";
+  Utils::createDirectories(local_metadir, S_IRWXU);
+  auto http = std::make_shared<HttpFake>(temp_dir.Path(), "", local_metadir / "repo");
+
+  UptaneRepo repo{local_metadir, "2021-07-04T16:33:27Z", "id0"};
+  repo.generateRepo(KeyType::kED25519);
+  const std::string hwid = "primary_hw";
+  repo.addImage(fake_meta_dir / "fake_meta/primary_firmware.txt", "primary_firmware.txt", hwid, "", {});
+  repo.addTarget("primary_firmware.txt", hwid, "CA:FE:A6:D2:84:9D", "");
+  repo.signTargets();
+
+  Config conf = UptaneTestCommon::makeTestConfig(temp_dir, http->tls_server);
+  auto storage = INvStorage::newStorage(conf.storage);
+  UptaneTestCommon::TestAktualizr aktualizr(conf, storage, http);
+
+  // attach the autoclean handler
+  boost::signals2::connection ac_conn =
+      aktualizr.SetSignalHandler(std::bind(targets_autoclean_cb, std::ref(aktualizr), std::placeholders::_1));
+  aktualizr.Initialize();
+
+  {
+    result::UpdateCheck update_result = aktualizr.CheckUpdates().get();
+    aktualizr.Download(update_result.updates).get();
+
+    EXPECT_EQ(aktualizr.GetStoredTargets().size(), 1);
+
+    result::Install install_result = aktualizr.Install(update_result.updates).get();
+    EXPECT_TRUE(install_result.dev_report.success);
+
+    EXPECT_EQ(aktualizr.GetStoredTargets().size(), 1);
+  }
+
+  // second install
+  repo.emptyTargets();
+  repo.addImage(fake_meta_dir / "fake_meta/dummy_firmware.txt", "dummy_firmware.txt", hwid, "", {});
+  repo.addTarget("dummy_firmware.txt", hwid, "CA:FE:A6:D2:84:9D", "");
+  repo.signTargets();
+
+  {
+    result::UpdateCheck update_result = aktualizr.CheckUpdates().get();
+    aktualizr.Download(update_result.updates).get();
+
+    EXPECT_EQ(aktualizr.GetStoredTargets().size(), 2);
+
+    result::Install install_result = aktualizr.Install(update_result.updates).get();
+    EXPECT_TRUE(install_result.dev_report.success);
+
+    // first target was removed
+    std::vector<Uptane::Target> targets = aktualizr.GetStoredTargets();
+    ASSERT_EQ(targets.size(), 1);
+    EXPECT_EQ(targets[0].filename(), "dummy_firmware.txt");
+  }
+}
+
 /*
  * Initialize -> Install -> nothing to install.
  *

tests/metafake.h

@@ -10,9 +10,6 @@
 #include "utilities/utils.h"
 #include "uptane_repo.h"
 
-enum BackupList {
-};
-
 class MetaFake {
   public:
   MetaFake(const boost::filesystem::path &meta_dir_in)