Remove unnecessary transactions

The wcommit/wabort API is left as a placeholder. We'll add actual functionality once SQL database is reworked to have a separate table for file blobs. Signed-off-by: Anton Gerasimov <[email protected]>
advancedtelematic · Dec 13, 2018 · 12ecdd5 · 12ecdd5
1 parent 4086bda
commit 12ecdd5
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/src/libaktualizr/storage/sqlstorage.cc b/src/libaktualizr/storage/sqlstorage.cc
@@ -1122,11 +1122,15 @@ class SQLTargetWHandle : public StorageTargetWHandle {
     }
 
     row_id_ = sqlite3_last_insert_rowid(db_.get());
+
+    if (!db_.commitTransaction()) {
+      throw exc;
+    }
   }
 
   ~SQLTargetWHandle() override {
     if (!closed_) {
-      db_.commitTransaction();
+      wcommit();
     }
   }
 
@@ -1162,15 +1166,9 @@ class SQLTargetWHandle : public StorageTargetWHandle {
     return size;
   }
 
-  void wcommit() override {
-    closed_ = true;
-    db_.commitTransaction();
-  }
+  void wcommit() override { closed_ = true; }
 
-  void wabort() noexcept override {
-    closed_ = true;
-    db_.rollbackTransaction();
-  }
+  void wabort() noexcept override { closed_ = true; }
   friend class SQLTargetRHandle;
 
  private: