Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force use local report when prometheus monitor is used #1

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

Gnnng
Copy link
Member

@Gnnng Gnnng commented Jun 30, 2020

Due to some timing issues, the caliper report doesn't take account of all the transactions in the testing round, resulting in a lower TPS number compared to the result from the local report.

This is a known issue however a fix is not implemented yet.

This workaround forces the use of local report as it's more accurate at the moment.

@Gnnng Gnnng merged commit 9cecb1d into release-v0.3.2 Jun 30, 2020
@Gnnng Gnnng deleted the local-report branch June 30, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant