-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance types #18
Merged
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7264fee
feat: enhance types
johnhooks 3a60f96
docs: fix JSDoc parameter alignment
johnhooks 9e7b6b6
chore: upgrade to TS 5.0
johnhooks 538dbdf
fix: generic parameters
johnhooks eaafb55
fix: all type errors
johnhooks e7a6c15
chore: fix indentation of comments
johnhooks a0dcc94
chore: collapse comments
johnhooks efb6bb6
fix: remove .ts file
johnhooks 60a48ca
Check-in type declaration file
aduth f47702d
Remove extra param tags
aduth a959e52
feat: add typescript
johnhooks 1ce28e4
refactor: convert get-path to typescript
johnhooks 7e75cff
feat: enhance types
johnhooks ddd0fea
chore: upgrade to TS 5.0
johnhooks 7cad042
fix: generic parameters
johnhooks 9874238
chore: collapse comments
johnhooks f221369
Check-in type declaration file
aduth db80714
feat: convert to TypeScript
johnhooks b530fe2
fix: apply @aduth's suggestions
johnhooks f39b67d
chore: remove unnecessary type assertion
johnhooks 1d5c906
chore: apply @aduth's review suggestions
johnhooks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,16 @@ | ||
{ | ||
"presets": [ | ||
[ "@babel/env", { | ||
"modules": false | ||
} ] | ||
"@babel/preset-typescript", | ||
[ | ||
"@babel/env", | ||
{ | ||
"modules": false | ||
} | ||
] | ||
], | ||
"env": { | ||
"test": { | ||
"presets": [ "@babel/env" ] | ||
"presets": ["@babel/preset-typescript", "@babel/env"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,12 @@ | ||
{ | ||
"root": true, | ||
"extends": ["eslint:recommended", "prettier"], | ||
"plugins": ["prettier"], | ||
"parserOptions": { | ||
"ecmaVersion": 2020, | ||
"sourceType": "module" | ||
}, | ||
"extends": "@aduth/eslint-config", | ||
"env": { | ||
"es6": true, | ||
"browser": true, | ||
"mocha": true, | ||
"node": true | ||
}, | ||
"rules": { | ||
"prettier/prettier": "error" | ||
"no-redeclare": "off", | ||
"@typescript-eslint/no-redeclare": "error" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
es/ | ||
/es/* | ||
node_modules/ | ||
*.log | ||
dist/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import register from '@babel/register'; | ||
|
||
register({ extensions: ['.ts'] }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aduth I think this is from when we were going to check in the
es/index.d.ts
file, should it be reverted back to the original?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we could revert it to simplify the diff, but this appears to work just as well, so I'm also fine to keep as-is.