Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance types #18

Merged
merged 21 commits into from
Mar 25, 2023
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"presets": [
[ "@babel/env", {
"modules": false
} ]
"@babel/preset-typescript",
[
"@babel/env",
{
"modules": false
}
]
],
"env": {
"test": {
"presets": [ "@babel/env" ]
"presets": ["@babel/preset-typescript", "@babel/env"]
}
}
}
12 changes: 3 additions & 9 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
{
"root": true,
"extends": ["eslint:recommended", "prettier"],
"plugins": ["prettier"],
"parserOptions": {
"ecmaVersion": 2020,
"sourceType": "module"
},
"extends": "@aduth/eslint-config",
"env": {
"es6": true,
"browser": true,
"mocha": true,
"node": true
},
"rules": {
"prettier/prettier": "error"
"no-redeclare": "off",
"@typescript-eslint/no-redeclare": "error"
}
}
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
es/
/es/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth I think this is from when we were going to check in the es/index.d.ts file, should it be reverted back to the original?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we could revert it to simplify the diff, but this appears to work just as well, so I'm also fine to keep as-is.

node_modules/
*.log
dist/
3 changes: 3 additions & 0 deletions mocha-setup.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import register from '@babel/register';

register({ extensions: ['.ts'] });
Loading