Add a new smbus_writeread command to perform a write followed by a read in one transaction. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read in one transaction. Signed-off-by: <[email protected]>
adurbin
reviewed
Apr 5, 2017
smbus_rw.c
Outdated
| @@ -557,6 +626,8 @@ MAKE_PREREQ_PARAMS_FIXED_ARGS(smbus_send_byte_params, 4, | |||
| "<adapter> <address> <value>", 0); | |||
| MAKE_PREREQ_PARAMS_FIXED_ARGS(smbus_quick_params, 4, | |||
| "<adapter> <address> <0|1>", 0); | |||
| MAKE_PREREQ_PARAMS_FIXED_ARGS(smbus_writeread_params, 5, | |||
| "<adapter> <address> <read_count> <write_value>", 0); | |||
There was a problem hiding this comment.
Why is the read count before the write value? It's write then read, correct?
There was a problem hiding this comment.
Historical reason that I agree doesn't make sense for this tool: we have another tool that does something similar but take <read_count> ... so we had to put the read count first. In the iotool case I'll swap them.
There was a problem hiding this comment.
@adurbin some controllers actually program read count before the first byte write.
|
I changed the order. |
|
Shouldn't be this closed now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: [email protected]