swift3 conversion #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
thanksss!!!!!!!!!! |
|
Thanks! Bro |
AdrianFerreyra
suggested changes
Mar 1, 2017
| @@ -58,22 +55,22 @@ class GATracker { | |||
| #endif | |||
|
|
|||
| self.tid = tid | |||
| self.appName = NSBundle.mainBundle().infoDictionary!["CFBundleName"] as! String | |||
| let nsObject: AnyObject? = NSBundle.mainBundle().infoDictionary!["CFBundleShortVersionString"] | |||
| self.appName = Bundle.main.infoDictionary!["CFBundleName"] as! String | |||
There was a problem hiding this comment.
Should handle this conditional properly.
| self.appName = NSBundle.mainBundle().infoDictionary!["CFBundleName"] as! String | ||
| let nsObject: AnyObject? = NSBundle.mainBundle().infoDictionary!["CFBundleShortVersionString"] | ||
| self.appName = Bundle.main.infoDictionary!["CFBundleName"] as! String | ||
| let nsObject: AnyObject? = Bundle.main.infoDictionary!["CFBundleShortVersionString"] as AnyObject? |
There was a problem hiding this comment.
Same thing here.
let nsObject: AnyObject? = Bundle.main.infoDictionary["CFBundleShorVersionString"] as? AnyObject should do the job.
| let language = NSLocale.preferredLanguages().first | ||
| if language?.characters.count > 0 { | ||
| let language = NSLocale.preferredLanguages.first | ||
| if (language?.characters.count)! > 0 { |
There was a problem hiding this comment.
Maybe if (language?.characters.count ?? 0) > 0 ?
| @@ -111,7 +108,7 @@ class GATracker { | |||
| else { | |||
| if (error != nil) { | |||
There was a problem hiding this comment.
Optionals should not be handled like this. Use if let error = error or some other optional binding mechanism.
| @@ -111,7 +108,7 @@ class GATracker { | |||
| else { | |||
| if (error != nil) { | |||
| #if DEBUG | |||
| print(error!.description) | |||
| print(error!.localizedDescription) | |||
There was a problem hiding this comment.
Proper handling will help you get rid of this forced-unwrapping usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conversion to swift3