GSL warnings for discrete SCF functions #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I've added the same check that
compute_coeffs
has tocompute_coeffs_discrete
so that you get an error message rather than a list of zeros as your output ifGSL_ENABLED
isFalse
.I also added some warnings to the docstrings about the needs for GSL for these functions, obviously feel free to delete those.
Checklist
CHANGES.rst
)