Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: duplicate copyright string #476

Closed
chrillep opened this issue Jun 22, 2022 · 3 comments
Closed

bug: duplicate copyright string #476

chrillep opened this issue Jun 22, 2022 · 3 comments

Comments

@chrillep
Copy link
Contributor

chrillep commented Jun 22, 2022

__copyright__ = u'Copyright 2016, Adrien Vergé'

copyright = __copyright__

if you care :) . the footer in the docs has duplicate copyright string.

© Copyright Copyright 2016, Adrien Vergé Revision 058fef75.

Skärmavbild 2022-06-22 kl  11 26 59

https://github.com/sphinx-doc/sphinx/blob/1786e989ca16cac8f9d8a966a481d983d3b23f9c/doc/conf.py#L18
https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-copyright

@adrienverge
Copy link
Owner

Hello, thanks for noticing and sharing this!

Having the full copyright string in the __copyright__ (hence starting with the Copyright word) seems to be the common practice for setup.py files.
And copying copyright = __copyright__ in the docs is pretty handy.

We could use:

copyright = __copyright__.lstrip('Copyright ')

If you think it's worth it, I let you open a pull request :)

andrewimeson added a commit to andrewimeson/yamllint that referenced this issue Jun 22, 2022
@andrewimeson
Copy link
Contributor

I have a branch up for this, but I don't want to steal the commit credit from you two, so I'll hold off 😄

@chrillep
Copy link
Contributor Author

I have a branch up for this, but I don't want to steal the commit credit from you two, so I'll hold off 😄

you go ahead :)

andrewimeson added a commit to andrewimeson/yamllint that referenced this issue Jun 24, 2022
andrewimeson added a commit to andrewimeson/yamllint that referenced this issue Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants