Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --otp-delay option #376

Closed
wants to merge 1 commit into from
Closed

Add --otp-delay option #376

wants to merge 1 commit into from

Conversation

ShogunPanda
Copy link

This fixes #348.

I added a --otp-delay option, which takes a integer representing the number of seconds to wait before sending the OTP to the server.

@ShogunPanda
Copy link
Author

Up - Any plan to merge this?

@mrbaseman mrbaseman mentioned this pull request Nov 13, 2018
@mrbaseman
Copy link
Collaborator

We have decided to focus on finding the root cause of the issue, rather than adding another command line option. The improved debugging output of the recently released version 1.8.0 might help here. Does the http response code differ between the two cases "wrong password used" and "http requests sent too quickly after each other"?

@ShogunPanda ShogunPanda reopened this Jan 7, 2019
@ShogunPanda
Copy link
Author

As mentioned on #348, the issue is still happening for me so I think this PR is still needeed. Reopening.

@ShogunPanda
Copy link
Author

PR updated to match upstream master.

@DimitriPapadopoulos
Copy link
Collaborator

@ShogunPanda Have you been able to upgrade to 1.8.1 and investigate the root cause of this issue?

@ShogunPanda
Copy link
Author

@DimitriPapadopoulos Yup, I did. If you look in #348 I posted the output but there is nothing interesting. Apparently that server doesn't like the OTP to being sent too quickly.

@mrbaseman
Copy link
Collaborator

I have merged the change via #433. It will be in the next release.

@mrbaseman mrbaseman closed this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a delay when sending the OTP
3 participants