Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide the window when the window already at the front. #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jixiuf
Copy link

@jixiuf jixiuf commented May 15, 2023

close #11

@adrienverge
Copy link
Owner

Hello, I don't understand the initial problem nor issue #11. Could you explain what you're trying to solve, and what this commit is supposed to do?

@jixiuf
Copy link
Author

jixiuf commented May 15, 2023

  • When the corresponding key is pressed and this program is in background,
    its window is brought to the front.
  • When the corresponding key is pressed and this program is already at the
    front, the window would be minimized. < -------------------------------------------- see here
  • When the corresponding key is pressed and the program isn't launched yet,
    it is spawned by running the program in the command property.

@distefam
Copy link

This would be the desired behavior for me as well.

@adrienverge
Copy link
Owner

Sorry for the late reply.

When the corresponding key is pressed and this program is already at the
front, the window would be minimized. < -------------------------------------------- see here

OK, I tried it and it's nice.

Could you clean the commit? (remove all the commented code, letconst, code style and whitespaces, 2-space indentation, remove get_active_window() if global.display.focus_window should be used everywhere, etc.)

@jixiuf
Copy link
Author

jixiuf commented Dec 17, 2023

I don't use gnome any more ,you can just merge it and clean it by youself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how abou when the program is already at the front, then brought it to the bottom.
3 participants