Try packit 2 #6

adrianreber · 2021-04-12T11:32:59Z

Signed-off-by: Adrian Reber [email protected]

So, here's the enhanced version of the first try. Changes are: 1. The wrapper name is criu-ns instead of crns.py 2. The CLI is absolutely the same as for criu, since the script re-execl-s criu binary. E.g. scripts/criu-ns dump -t 1234 ... just works 3. Caller doesn't need to care about substituting CLI options, instead, the scripts analyzes the command line and a) replaces -t|--tree argument with virtual pid __if__ the target task lives in another pidns b) keeps the current cwd (and root) __if__ switches to another mntns. A limitation applies here -- cwd path should be the same in target ns, no "smart path mapping" is performed. So this script is for now only useful for mntns clones (which is our main goal at the moment). Signed-off-by: Pavel Emelyanov <[email protected]> Looks-good-to: Andrey Vagin <[email protected]>

In Py2 `range` returns a list and `xrange` creates a sequence object that evaluates lazily. In Py3 `range` is equivalent to `xrange` in Py2. Signed-off-by: Radostin Stoyanov <[email protected]> Signed-off-by: Andrei Vagin <[email protected]>

Signed-off-by: Radostin Stoyanov <[email protected]>

class ctypes.c_char_p Represents the C char * datatype when it points to a zero- terminated string. For a general character pointer that may also point to binary data, POINTER(c_char) must be used. The constructor accepts an integer address, or a bytes object. https://docs.python.org/3/library/ctypes.html#ctypes.c_char_p Signed-off-by: Radostin Stoyanov <[email protected]>

Change made through this commit: - Include copy of flog as a seperate tree. - Modify the makefile to add and compile flog code. Signed-off-by: prakritigoyal19 <[email protected]>

CID 302713 (#1 of 1): Missing varargs init or cleanup (VARARGS) va_end was not called for argptr. Signed-off-by: Adrian Reber <[email protected]>

criu-ns performs double fork, which results in criu restore using PID=2. Thus, if a user is trying to restore a process with that PID, the restore will fail. Signed-off-by: Radostin Stoyanov <[email protected]>

When criu restore runs as PID=1 it has an additional responsibility to reap zombie processes. Signed-off-by: Radostin Stoyanov <[email protected]> Signed-off-by: Andrei Vagin <[email protected]>

Some kernels have W^X mitigation, which means they won't execute memory blocks if that memory block is also writable or ever was writable. This patch enables CRIU to run on such kernels. 1. Align .data section to a page. 2. mmap a memory block for parasite as RX. 3. mprotect everything after .text as RW. Signed-off-by: Michał Cłapiński <[email protected]>

The clang analyzer, scan-build, cannot correctly handle the LOCK_BUG_ON() macro. At multiple places there is the following warning: Error: CLANG_WARNING: criu/pie/restorer.c:1221:4: warning: Dereference of null pointer include/common/lock.h:14:35: note: expanded from macro 'LOCK_BUG_ON' *(volatile unsigned long *)NULL = 0xdead0000 + __LINE__ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ This just disable the clang analyzer for the LOCK_BUG_ON() macro. Signed-off-by: Adrian Reber <[email protected]>

Using scan-build there is a warning about infect.c:231:17: warning: The left operand of '!=' is a garbage value if (ss->state != 'Z') { which is a false positive as every process will have a 'Status' field, but initializing the structure makes the clang analyzer silent. Signed-off-by: Adrian Reber <[email protected]>

Signed-off-by: Adrian Reber <[email protected]>

The function collect_one_unixsk() has a parameter 'i' and at the same time has a variable, in a loop, with the name 'i'. This is no real error or problem, because the function parameter 'i' is never used in the whole function. Just trying to reduce confusion and making a code checker happy. Signed-off-by: Adrian Reber <[email protected]>

Using strsep() moves the pointer of the original string and this introduces a copy of the malloc()ed memory to be able to free() it later. Signed-off-by: Adrian Reber <[email protected]>

Ignore coverity errors about CHECKED_RETURN. Signed-off-by: Adrian Reber <[email protected]>

Signed-off-by: Adrian Reber <[email protected]>

Coverity does not understand how close_fds() works. Signed-off-by: Adrian Reber <[email protected]>

…ative Signed-off-by: Adrian Reber <[email protected]>

criu/sk-unix.c:1173: chroot_call: Calling chroot: "chroot(".")". criu/sk-unix.c:1175: chroot: Calling function "close_safe" after chroot() but before calling chdir("/"). criu/sk-unix.c:1251: chroot_call: Calling chroot: "chroot(".")". criu/sk-unix.c:1263: chroot: Calling function "print_on_level" after chroot() but before calling chdir("/"). Coverity also says: 175312, 175313 Insecure chroot If a call to chroot is not followed by a call to chdir("/") the chroot jail confinement can be violated. Signed-off-by: Adrian Reber <[email protected]>

criu/pagemap.c:245: negative_return_fn: Function "img_raw_fd(pr->pi)" returns a negative number. criu/pagemap.c:245: assign: Assigning: "fd" = "img_raw_fd(pr->pi)". criu/pagemap.c:258: negative_returns: "fd" is passed to a parameter that cannot be negative. criu/ipc_ns.c:762: negative_return_fn: Function "img_raw_fd(img)" returns a negative number. criu/ipc_ns.c:762: assign: Assigning: "ifd" = "img_raw_fd(img)". criu/ipc_ns.c:768: negative_returns: "ifd" is passed to a parameter that cannot be negative. Signed-off-by: Adrian Reber <[email protected]>

criu/namespaces.c:529: var_decl: Declaring variable "path" without initializer. criu/namespaces.c:602: uninit_use_in_call: Using uninitialized value "*path" as argument to "%s" when calling "print_on_level". Signed-off-by: Adrian Reber <[email protected]>

CRIU is already using multiple CI systems and not just Travis. This renames all Travis related things to 'ci' to show it is actually independent of Travis. Just a simple rename. Signed-off-by: Adrian Reber <[email protected]>

When a TF refuses a new test request, it sends back reason: 'Bad Request' errors: (e.g.) {'environments': {'0': {'arch': "must be one of: 'x86_64'"}}} While the reason is nicer, it doesn't contain any info so users would need to wait for us to tell them what actually happened. So far we've hit only the unsupported arch error, so let's extract it from the error json. adrianreber/criu#6 (comment)

Signed-off-by: Adrian Reber <[email protected]>

thrix · 2021-04-15T14:05:19Z

I'm afraid aarch64 is not yet supported architecture in tests. @thrix would tell you more.
I'll try to improve the error message (Bad Request).

Yeah, not yet ... I fillled: https://gitlab.com/testing-farm/general/-/issues/23

Signed-off-by: Adrian Reber <[email protected]>

When a TF refuses a new test request, it sends back reason: 'Bad Request' errors: (e.g.) {'environments': {'0': {'arch': "must be one of: 'x86_64'"}}} While the reason is nicer, it doesn't contain any info so users would need to wait for us to tell them what actually happened. So far we've hit only the unsupported arch error, so let's extract it from the error json. adrianreber/criu#6 (comment)

Signed-off-by: Adrian Reber <[email protected]>

Error message is in 'errors', not 'message' When a TF refuses a new test request, it sends back reason: 'Bad Request' errors: (e.g.) {'environments': {'0': {'arch': "must be one of: 'x86_64'"}}} While the reason is nicer, it doesn't contain any info so users would need to wait for us to tell them what actually happened. So far we've hit only the unsupported arch error, so let's extract it from the error json. adrianreber/criu#6 (comment) Reviewed-by: None <None>

Signed-off-by: Adrian Reber <[email protected]>

TomasTomecek · 2021-04-16T18:11:29Z

Congrats on getting green tests, you rock!

psss · 2021-04-19T11:44:51Z

Just note, if you don't plan to enable multiple tests it's also possible to include the whole config within the plan:

environment:
    CD_TO_TOP: 1
    SKIP_CI_PREP: 1
    CC: gcc
prepare:
    script:
      - ./scripts/ci/prepare-for-fedora-rawhide.sh
      - dnf install -y libselinux-devel
      - systemctl stop sssd
execute:
    script:
      - ln -sf /usr/include/google/protobuf/descriptor.proto images/google/protobuf/descriptor.proto
      - ./scripts/ci/run-ci-tests.sh

Scripts defined directly under the execute step are run in the git repo root so the CD_TO_TOP variable would not be needed.

adrianreber · 2021-04-19T11:55:19Z

@psss Thanks. I will try that. That looks simpler and easier to read.

github-actions · 2021-05-20T01:06:08Z

A friendly reminder that this PR had no activity for 30 days.

codecov-commenter · 2024-12-06T05:27:31Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Running the zdtm/static/unlink_regular00 test on Ubuntu 24.04 on aarch64 results in following error: # ./zdtm.py run -t zdtm/static/unlink_regular00 -k always userns is supported === Run 1/1 ================ zdtm/static/unlink_regular00 ==================== Run zdtm/static/unlink_regular00 in ns ==================== Skipping rtc at root Start test Test is SUID ./unlink_regular00 --pidfile=unlink_regular00.pid --outfile=unlink_regular00.out --dirname=unlink_regular00.test Run criu dump *** buffer overflow detected ***: terminated ############# Test zdtm/static/unlink_regular00 FAIL at CRIU dump ############## Test output: ================================ <<< ================================ Send the 9 signal to 47 Wait for zdtm/static/unlink_regular00(47) to die for 0.100000 ##################################### FAIL ##################################### According to the backtrace: #0 __pthread_kill_implementation (threadid=281473158467616, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 #1 0x0000ffff93477690 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 0x0000ffff9342cb3c in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #3 0x0000ffff93417e00 in __GI_abort () at ./stdlib/abort.c:79 #4 0x0000ffff9346abf0 in __libc_message_impl (fmt=fmt@entry=0xffff93552a78 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:132 #5 0x0000ffff934e81a8 in __GI___fortify_fail (msg=msg@entry=0xffff93552a28 "buffer overflow detected") at ./debug/fortify_fail.c:24 #6 0x0000ffff934e79e4 in __GI___chk_fail () at ./debug/chk_fail.c:28 #7 0x0000ffff934e9070 in ___snprintf_chk (s=s@entry=0xffffc6ed04a3 "testfile", maxlen=maxlen@entry=4056, flag=flag@entry=2, slen=slen@entry=4053, format=format@entry=0xaaaacffe3888 "link_remap.%d") at ./debug/snprintf_chk.c:29 #8 0x0000aaaacff4b8b8 in snprintf (__fmt=0xaaaacffe3888 "link_remap.%d", __n=4056, __s=0xffffc6ed04a3 "testfile") at /usr/include/aarch64-linux-gnu/bits/stdio2.h:54 #9 create_link_remap (path=path@entry=0xffffc6ed2901 "/zdtm/static/unlink_regular00.test/subdir/testfile", len=len@entry=60, lfd=lfd@entry=20, idp=idp@entry=0xffffc6ed14ec, nsid=nsid@entry=0xaaaada2bac00, parms=parms@entry=0xffffc6ed2808, fallback=0xaaaacff4c6c0 <dump_linked_remap+96>, fallback@entry=0xffffc6ed2797) at criu/files-reg.c:1164 #10 0x0000aaaacff4c6c0 in dump_linked_remap (path=path@entry=0xffffc6ed2901 "/zdtm/static/unlink_regular00.test/subdir/testfile", len=len@entry=60, parms=parms@entry=0xffffc6ed2808, lfd=lfd@entry=20, id=id@entry=12, nsid=nsid@entry=0xaaaada2bac00, fallback=fallback@entry=0xffffc6ed2797) at criu/files-reg.c:1198 #11 0x0000aaaacff4d8b0 in check_path_remap (nsid=0xaaaada2bac00, id=12, lfd=20, parms=0xffffc6ed2808, link=<optimized out>) at criu/files-reg.c:1426 #12 dump_one_reg_file (lfd=20, id=12, p=0xffffc6ed2808) at criu/files-reg.c:1827 checkpoint-restore#13 0x0000aaaacff51078 in dump_one_file (pid=<optimized out>, fd=4, lfd=20, opts=opts@entry=0xaaaada2ba2c0, ctl=ctl@entry=0xaaaada2c4d50, e=e@entry=0xffffc6ed39c8, dfds=dfds@entry=0xaaaada2c3d40) at criu/files.c:581 checkpoint-restore#14 0x0000aaaacff5176c in dump_task_files_seized (ctl=ctl@entry=0xaaaada2c4d50, item=item@entry=0xaaaada2b8f80, dfds=dfds@entry=0xaaaada2c3d40) at criu/files.c:657 checkpoint-restore#15 0x0000aaaacff3d3c0 in dump_one_task (parent_ie=0x0, item=0xaaaada2b8f80) at criu/cr-dump.c:1679 checkpoint-restore#16 cr_dump_tasks (pid=<optimized out>) at criu/cr-dump.c:2224 checkpoint-restore#17 0x0000aaaacff163a0 in main (argc=<optimized out>, argv=0xffffc6ed40e8, envp=<optimized out>) at criu/crtools.c:293 This line is the problem: snprintf(tmp + 1, sizeof(link_name) - (size_t)(tmp - link_name - 1), "link_remap.%d", rfe.id); The problem was that the `-1` was on the inside of the braces and not on the outside. This way the destination size was increase by 1 instead of being decreased by 1 which triggered the Signed-off-by: Adrian Reber <[email protected]>

Running the zdtm/static/unlink_regular00 test on Ubuntu 24.04 on aarch64 results in following error: # ./zdtm.py run -t zdtm/static/unlink_regular00 -k always userns is supported === Run 1/1 ================ zdtm/static/unlink_regular00 ==================== Run zdtm/static/unlink_regular00 in ns ==================== Skipping rtc at root Start test Test is SUID ./unlink_regular00 --pidfile=unlink_regular00.pid --outfile=unlink_regular00.out --dirname=unlink_regular00.test Run criu dump *** buffer overflow detected ***: terminated ############# Test zdtm/static/unlink_regular00 FAIL at CRIU dump ############## Test output: ================================ <<< ================================ Send the 9 signal to 47 Wait for zdtm/static/unlink_regular00(47) to die for 0.100000 ##################################### FAIL ##################################### According to the backtrace: #0 __pthread_kill_implementation (threadid=281473158467616, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 #1 0x0000ffff93477690 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 0x0000ffff9342cb3c in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #3 0x0000ffff93417e00 in __GI_abort () at ./stdlib/abort.c:79 #4 0x0000ffff9346abf0 in __libc_message_impl (fmt=fmt@entry=0xffff93552a78 "*** %s ***: terminated\n") at ../sysdeps/posix/libc_fatal.c:132 #5 0x0000ffff934e81a8 in __GI___fortify_fail (msg=msg@entry=0xffff93552a28 "buffer overflow detected") at ./debug/fortify_fail.c:24 #6 0x0000ffff934e79e4 in __GI___chk_fail () at ./debug/chk_fail.c:28 #7 0x0000ffff934e9070 in ___snprintf_chk (s=s@entry=0xffffc6ed04a3 "testfile", maxlen=maxlen@entry=4056, flag=flag@entry=2, slen=slen@entry=4053, format=format@entry=0xaaaacffe3888 "link_remap.%d") at ./debug/snprintf_chk.c:29 #8 0x0000aaaacff4b8b8 in snprintf (__fmt=0xaaaacffe3888 "link_remap.%d", __n=4056, __s=0xffffc6ed04a3 "testfile") at /usr/include/aarch64-linux-gnu/bits/stdio2.h:54 #9 create_link_remap (path=path@entry=0xffffc6ed2901 "/zdtm/static/unlink_regular00.test/subdir/testfile", len=len@entry=60, lfd=lfd@entry=20, idp=idp@entry=0xffffc6ed14ec, nsid=nsid@entry=0xaaaada2bac00, parms=parms@entry=0xffffc6ed2808, fallback=0xaaaacff4c6c0 <dump_linked_remap+96>, fallback@entry=0xffffc6ed2797) at criu/files-reg.c:1164 #10 0x0000aaaacff4c6c0 in dump_linked_remap (path=path@entry=0xffffc6ed2901 "/zdtm/static/unlink_regular00.test/subdir/testfile", len=len@entry=60, parms=parms@entry=0xffffc6ed2808, lfd=lfd@entry=20, id=id@entry=12, nsid=nsid@entry=0xaaaada2bac00, fallback=fallback@entry=0xffffc6ed2797) at criu/files-reg.c:1198 #11 0x0000aaaacff4d8b0 in check_path_remap (nsid=0xaaaada2bac00, id=12, lfd=20, parms=0xffffc6ed2808, link=<optimized out>) at criu/files-reg.c:1426 #12 dump_one_reg_file (lfd=20, id=12, p=0xffffc6ed2808) at criu/files-reg.c:1827 checkpoint-restore#13 0x0000aaaacff51078 in dump_one_file (pid=<optimized out>, fd=4, lfd=20, opts=opts@entry=0xaaaada2ba2c0, ctl=ctl@entry=0xaaaada2c4d50, e=e@entry=0xffffc6ed39c8, dfds=dfds@entry=0xaaaada2c3d40) at criu/files.c:581 checkpoint-restore#14 0x0000aaaacff5176c in dump_task_files_seized (ctl=ctl@entry=0xaaaada2c4d50, item=item@entry=0xaaaada2b8f80, dfds=dfds@entry=0xaaaada2c3d40) at criu/files.c:657 checkpoint-restore#15 0x0000aaaacff3d3c0 in dump_one_task (parent_ie=0x0, item=0xaaaada2b8f80) at criu/cr-dump.c:1679 checkpoint-restore#16 cr_dump_tasks (pid=<optimized out>) at criu/cr-dump.c:2224 checkpoint-restore#17 0x0000aaaacff163a0 in main (argc=<optimized out>, argv=0xffffc6ed40e8, envp=<optimized out>) at criu/crtools.c:293 This line is the problem: snprintf(tmp + 1, sizeof(link_name) - (size_t)(tmp - link_name - 1), "link_remap.%d", rfe.id); The problem was that the `-1` was on the inside of the braces and not on the outside. This way the destination size was increase by 1 instead of being decreased by 1 which triggered the buffer overflow detection. Signed-off-by: Adrian Reber <[email protected]>

xemul and others added 30 commits November 8, 2020 01:55

python: Replace xrange with range

ca5c93d

In Py2 `range` returns a list and `xrange` creates a sequence object that evaluates lazily. In Py3 `range` is equivalent to `xrange` in Py2. Signed-off-by: Radostin Stoyanov <[email protected]> Signed-off-by: Andrei Vagin <[email protected]>

criu-ns: Convert to python3 style print() syntax

226efaa

Signed-off-by: Radostin Stoyanov <[email protected]>

criu-ns: Print usage info when no args provided

3f71897

Signed-off-by: Radostin Stoyanov <[email protected]>

Add flog to CRIU

5329446

Change made through this commit: - Include copy of flog as a seperate tree. - Modify the makefile to add and compile flog code. Signed-off-by: prakritigoyal19 <[email protected]>

flog: Missing varargs init or cleanup (VARARGS)

e180172

CID 302713 (#1 of 1): Missing varargs init or cleanup (VARARGS) va_end was not called for argptr. Signed-off-by: Adrian Reber <[email protected]>

criu-ns: Use PID 1 on restore

265569a

criu-ns performs double fork, which results in criu restore using PID=2. Thus, if a user is trying to restore a process with that PID, the restore will fail. Signed-off-by: Radostin Stoyanov <[email protected]>

cr-restore: Wait child & reap zombies if PID=1

53dd29e

When criu restore runs as PID=1 it has an additional responsibility to reap zombie processes. Signed-off-by: Radostin Stoyanov <[email protected]> Signed-off-by: Andrei Vagin <[email protected]>

lib/py: remove unused variable

6a9bff8

Signed-off-by: Adrian Reber <[email protected]>

coredump: remove two unused variables

bbca79a

Signed-off-by: Adrian Reber <[email protected]>

bfd: remove unused line

407d3fe

Signed-off-by: Adrian Reber <[email protected]>

Use 'is None' instead of '== None'

eb74152

Signed-off-by: Adrian Reber <[email protected]>

autofs: Potential leak of memory pointed to by 'token'

42e3e2e

Using strsep() moves the pointer of the original string and this introduces a copy of the malloc()ed memory to be able to free() it later. Signed-off-by: Adrian Reber <[email protected]>

coverity: ignore CHECKED_RETURN

62ab67e

Ignore coverity errors about CHECKED_RETURN. Signed-off-by: Adrian Reber <[email protected]>

vdso-compat: let coverity know that the function does not return

36f9700

Signed-off-by: Adrian Reber <[email protected]>

cr-dump: Potential leak of memory pointed to by 'si'

53501e5

Signed-off-by: Adrian Reber <[email protected]>

restore: Value stored to 'ret' is never read

73ed071

Signed-off-by: Adrian Reber <[email protected]>

coverity: fix parameter_hidden: declaration hides parameter

fc20d28

Signed-off-by: Adrian Reber <[email protected]>

dump: Potential leak of memory pointed to by 'si'

5527329

Signed-off-by: Adrian Reber <[email protected]>

util: fix double_close false positive

d95c268

Coverity does not understand how close_fds() works. Signed-off-by: Adrian Reber <[email protected]>

cr-dump: get_service_fd() is passed to a parameter that cannot be neg…

ef4ec32

…ative Signed-off-by: Adrian Reber <[email protected]>

CI: rename 'travis' to 'ci'

0e47308

CRIU is already using multiple CI systems and not just Travis. This renames all Travis related things to 'ci' to show it is actually independent of Travis. Just a simple rename. Signed-off-by: Adrian Reber <[email protected]>

jpopelka mentioned this pull request Apr 15, 2021

Fix how errors are handled when submitting a test to TF packit/packit-service#1055

Merged

adrianreber added 4 commits April 15, 2021 12:14

more setenforce 0

8984683

Signed-off-by: Adrian Reber <[email protected]>

install libselinux-devel

3508268

Signed-off-by: Adrian Reber <[email protected]>

fix missing ;

d9b744f

Signed-off-by: Adrian Reber <[email protected]>

disable sssd

9f7ec7a

Signed-off-by: Adrian Reber <[email protected]>

enable selinux again and keep-going

8430725

Signed-off-by: Adrian Reber <[email protected]>

echo 1 > /proc/sys/vm/unprivileged_userfaultfd

a87162e

Signed-off-by: Adrian Reber <[email protected]>

adrianreber added 9 commits April 15, 2021 15:12

test: remove ../criu from all directory paths

19cd059

Signed-off-by: Adrian Reber <[email protected]>

one more change

597adf9

Signed-off-by: Adrian Reber <[email protected]>

try this

c325430

Signed-off-by: Adrian Reber <[email protected]>

allow userfaultfd in userns

19235aa

Signed-off-by: Adrian Reber <[email protected]>

remove '

1888573

Signed-off-by: Adrian Reber <[email protected]>

add some ;

624844e

Signed-off-by: Adrian Reber <[email protected]>

Skip tun_ns on F33

b2a2a01

Signed-off-by: Adrian Reber <[email protected]>

Install libbsd-devel on Fedora

1183274

Signed-off-by: Adrian Reber <[email protected]>

ci: skip error injection on 5.12

fe31d83

Signed-off-by: Adrian Reber <[email protected]>

github-actions bot added the stale-pr label May 20, 2021

adrianreber force-pushed the criu-dev branch from b98bbda to 0c38a94 Compare September 23, 2021 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try packit 2 #6

Try packit 2 #6

adrianreber commented Apr 12, 2021

thrix commented Apr 15, 2021

TomasTomecek commented Apr 16, 2021

psss commented Apr 19, 2021

adrianreber commented Apr 19, 2021

github-actions bot commented May 20, 2021

codecov-commenter commented Dec 6, 2024

Try packit 2 #6

Are you sure you want to change the base?

Try packit 2 #6

Conversation

adrianreber commented Apr 12, 2021

thrix commented Apr 15, 2021

TomasTomecek commented Apr 16, 2021

psss commented Apr 19, 2021

adrianreber commented Apr 19, 2021

github-actions bot commented May 20, 2021

codecov-commenter commented Dec 6, 2024

Welcome to Codecov 🎉