Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for records #273

Closed
11 tasks done
Tracked by #9
adrianoc opened this issue Mar 25, 2024 · 0 comments
Closed
11 tasks done
Tracked by #9

Add support for records #273

adrianoc opened this issue Mar 25, 2024 · 0 comments
Labels
enhancement New feature or request feature:records wip Work In Progress
Milestone
2.12

Comments

@adrianoc
Copy link
Owner

adrianoc commented Mar 25, 2024 •
edited
Loading

Records were introduced in C# 9.0

We should also support record structs introduced in C# 10.

given a record R

Specific for struct records

  • Adds IsReadOnly attribute to all methods and the getter of each added property

Specific for class records
@adrianoc adrianoc changed the title Add support for [records](https://github.com/dotnet/csharplang/blob/main/proposals/csharp-9.0/records.md) Add support for records Mar 25, 2024
This was referenced Mar 25, 2024
Closed
Open
@adrianoc adrianoc added the enhancement New feature or request label Mar 29, 2024
@adrianoc adrianoc added this to the 2.12 milestone Mar 29, 2024
@adrianoc adrianoc added the wip Work In Progress label Apr 14, 2024
adrianoc added a commit that referenced this issue Apr 30, 2024
@adrianoc
feat: adds support for simplest record declaration (#273)
bb79a8c
adrianoc added a commit that referenced this issue Apr 30, 2024
@adrianoc
add 'record' type in test to sync with ElementKind values (#273)
0f006f5
adrianoc added a commit that referenced this issue Apr 30, 2024
@adrianoc
introduces PropertyGenerator extracted from PropertyDeclarationVisitor
c8dbbfa 
1. Also includes some minor refactorings
2. This work is a preparation for #273 to avoid code duplication
adrianoc added a commit that referenced this issue Apr 30, 2024
@adrianoc
updates settings code to take records into account (#273)
1b3bff7
adrianoc added a commit that referenced this issue Apr 30, 2024
@adrianoc
adds a public property for each primary contructor parameter (#273)
0c5e134
adrianoc added a commit that referenced this issue Apr 30, 2024
@adrianoc
ensures primary constructors are handled (#273)
0f29c75 
this means that a contructor is emmited for the primary constructor
adrianoc added a commit that referenced this issue May 10, 2024
@adrianoc
implements code generation for EqualityContract properties for records (
77a573d 
#273)
adrianoc added a commit that referenced this issue May 10, 2024
@adrianoc
implements 'IEquatable<T>' interface on records (#273)
5fbf71d
adrianoc added a commit that referenced this issue May 25, 2024
@adrianoc
calls base record constructor (#273)
0372d0c 
also, only emit properties for constructor parameters that does not match any base constructor parameter
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
feat: adds support for simplest record declaration (#273)
cdcb5be
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
add 'record' type in test to sync with ElementKind values (#273)
91f2723
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
introduces PropertyGenerator extracted from PropertyDeclarationVisitor
57c53ea 
1. Also includes some minor refactorings
2. This work is a preparation for #273 to avoid code duplication
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
updates settings code to take records into account (#273)
d0268f8
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
adds a public property for each primary contructor parameter (#273)
1368788
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
ensures primary constructors are handled (#273)
e3b20b9 
this means that a contructor is emmited for the primary constructor
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
implements code generation for EqualityContract properties for records (
cc96bdf 
#273)
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
implements 'IEquatable<T>' interface on records (#273)
199f41f
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
calls base record constructor (#273)
08c5f38 
also, only emit properties for constructor parameters that does not match any base constructor parameter
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
feat: adds support for simplest record declaration (#273)
afb6e63
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
add 'record' type in test to sync with ElementKind values (#273)
6634d3a
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
introduces PropertyGenerator extracted from PropertyDeclarationVisitor
d12ba6a 
1. Also includes some minor refactorings
2. This work is a preparation for #273 to avoid code duplication
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
updates settings code to take records into account (#273)
3499989
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
adds a public property for each primary contructor parameter (#273)
358f0a3
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
ensures primary constructors are handled (#273)
b4be8a5 
this means that a contructor is emmited for the primary constructor
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
implements code generation for EqualityContract properties for records (
aaeec3f 
#273)
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
implements 'IEquatable<T>' interface on records (#273)
0b0c67e
adrianoc added a commit that referenced this issue Jun 9, 2024
@adrianoc
calls base record constructor (#273)
869d03e 
also, only emit properties for constructor parameters that does not match any base constructor parameter
adrianoc added a commit that referenced this issue Jun 11, 2024
@adrianoc
fixes for record struct handling (#273)
32fc64a
adrianoc added a commit that referenced this issue Jun 11, 2024
@adrianoc
adds IsReadOnlyAttribute to appropriate members of record structs (#273)
eb82886
adrianoc added a commit that referenced this issue Jun 19, 2024
@adrianoc
fixes for record struct handling (#273)
fd21509
adrianoc added a commit that referenced this issue Jun 19, 2024
@adrianoc
adds IsReadOnlyAttribute to appropriate members of record structs (#273)
77f41f8
@adrianoc adrianoc mentioned this issue Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature:records wip Work In Progress
Projects
None yet
Milestone
2.12
Development

No branches or pull requests
1 participant
@adrianoc