Added option for logging response data #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata. Signed-off-by: Adrian Moreno <[email protected]>
|
Hey @GreenCee - so sorry for the time it took to review and merge this PR. I lost track of it... I've just renamed "response" to "responseData" to be a little bit more precise in what's being logged and also added the new option into the README file so that users know how to configure it. Thanks a lot for the contribution 🏆 |
adrianmo
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default-false option to persist existing behavior
This allows additional information from the request response to be sent to App Insights. We are using this feature to log and capture query diagnostics from our CosmosDB plugin, but should work for any JMeter plugins seamlessly.