refactor(sync): add $http promise arguments to options

Backbone methods that internally use Backbone.sync (like fetch, create, save) accept error and success callback functions with the arguments `collection` (or `model`), `response`, `options`. In normal Backbone.js using $.ajax, options.xhr gets set to a jqXHR object. Although $http doesn't give us an XHR object to use, this makes the differing APIs a little bit closer.
adrianlee44 · Oct 14, 2014 · 4df0c82 · 4df0c82
1 parent 6bef93e
commit 4df0c82
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/ng-backbone.js b/ng-backbone.js
@@ -57,13 +57,25 @@
           params.params = options.data;
         }
 
-        var xhr = options.xhr = ajax(_.extend(params, options)).
-          success(function(data) {
+        var xhr = ajax(_.extend(params, options)).
+          success(function(data, status, headers, config) {
+            options.xhr = {
+              status: status,
+              headers: headers,
+              config: config
+            };
+
             if (!isUndefined(options.success) && _.isFunction(options.success)) {
               options.success(data);
             }
           }).
-          error(function(data) {
+          error(function(data, status, headers, config) {
+            options.xhr = {
+              status: status,
+              headers: headers,
+              config: config
+            };
+
             if (!isUndefined(options.error) && _.isFunction(options.error)) {
               options.error(data);
             }