Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Hessians on non-tracer outputs #99

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented May 23, 2024

Fix #98 by adding the appropriate methods for converting Hessian tracers to a matrix when the output is not a tracer or dual

Add connectivity, gradient and Hessian tests for f(x) = 0

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (f1bf915) to head (a88883f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   79.62%   79.88%   +0.25%     
==========================================
  Files          17       17              
  Lines         702      706       +4     
==========================================
+ Hits          559      564       +5     
+ Misses        143      142       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle requested a review from adrhill May 23, 2024 09:04
@adrhill adrhill changed the title Support f(x) = 0 Support Hessians on non-tracer outputs May 23, 2024
@adrhill adrhill merged commit 5598602 into main May 23, 2024
4 checks passed
@adrhill
Copy link
Owner

adrhill commented May 23, 2024

Thanks!

@adrhill adrhill deleted the gd/trivial_functions_hessian branch May 23, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support functions that don't depend on the input
3 participants