Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AbstractTracer subtype of Real #92

Merged
merged 2 commits into from
May 22, 2024
Merged

Make AbstractTracer subtype of Real #92

merged 2 commits into from
May 22, 2024

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented May 22, 2024

Make AbstractTracer subtype of Real instead of Number. Closes #91.

Not sure whether we need to consider this as breaking, since tracer types are considered internals. However, the documentation mentioned tracers subtyping Number.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.91%. Comparing base (298837f) to head (92db98c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   78.92%   78.91%   -0.01%     
==========================================
  Files          17       17              
  Lines         707      702       -5     
==========================================
- Hits          558      554       -4     
+ Misses        149      148       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill
Copy link
Owner Author

adrhill commented May 22, 2024

Not sure whether we need to consider this as breaking, since tracer types are considered internals.

This should be considered breaking because SCT might stop working on some functions it previously worked on.

@adrhill adrhill merged commit f1bf915 into main May 22, 2024
4 checks passed
@adrhill adrhill deleted the ah/real branch May 22, 2024 23:16
@gdalle
Copy link
Collaborator

gdalle commented May 23, 2024

why did you add Complex everywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make AbstractTracer a subtype of Real, not Number
3 participants