Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests to improve modularity and debloat runtests.jl #46

Merged
merged 6 commits into from
May 5, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented May 5, 2024

This is strictly copy-paste and moving stuff around

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.98%. Comparing base (e3dca46) to head (c41c9dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   73.98%   73.98%           
=======================================
  Files           9        9           
  Lines         319      319           
=======================================
  Hits          236      236           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle requested a review from adrhill May 5, 2024 13:29
test/brusselator.jl Show resolved Hide resolved
@adrhill
Copy link
Owner

adrhill commented May 5, 2024

I don't see a downside in updating the "real-world tests" to make use of the ADTypes interface.

@adrhill
Copy link
Owner

adrhill commented May 5, 2024

Feel free to merge if you just want to quickly get this done.

@gdalle gdalle merged commit bf32fee into main May 5, 2024
2 checks passed
@gdalle gdalle deleted the gd/split_tests branch May 5, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants