Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 2-to-1 overloads on arbitrary types #197

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented Oct 1, 2024

Previously, 2-to-1 overloads were hardcoded on Real numbers.
This PR generalizes this to arbitrary types, simplifying the code needed to avoid ambiguity errors.
This is also the first step towards a ForwardDiff extension addressing #196.

@adrhill
Copy link
Owner Author

adrhill commented Oct 1, 2024

JET.jl and DataInterpolations tests fail, but it looks unrelated to this PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.05%. Comparing base (65a52ad) to head (92029d3).

Files with missing lines Patch % Lines
src/overloads/utils.jl 30.76% 9 Missing ⚠️
src/overloads/hessian_tracer.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   89.45%   91.05%   +1.60%     
==========================================
  Files          48       47       -1     
  Lines        2057     2080      +23     
==========================================
+ Hits         1840     1894      +54     
+ Misses        217      186      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill merged commit 702b2d0 into main Oct 1, 2024
6 checks passed
@adrhill adrhill deleted the ah/gen-with-type branch October 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants