Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit #1

Merged
merged 5 commits into from
Jan 9, 2025
Merged

initial commit #1

merged 5 commits into from
Jan 9, 2025

Conversation

rishh18
Copy link
Contributor

@rishh18 rishh18 commented Nov 12, 2024

No description provided.

ankushkumar5
ankushkumar5 requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ankushkumar5 ankushkumar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please make changes based on comments.
  • Also, the signing info needs updation. Will share the new account that you need to use for signing over dm. Please rebuild the framework and recommit it.

ApMobileSDK.podspec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change SDK v to 1.0.0

Package.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binaryTarget URL should be https://github.com/adpushup/ApiOSSDK/releases/download/1.0.0/ApMobileSDK.xcframework.zip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary URL still references old binary: https://github.com/rishh18/ApMobileSDK/releases/download/0.0.1/ApMobileSDK.xcframework.zip
Please change it to: https://github.com/rishh18/ApMobileSDK/releases/download/1.0.0/ApMobileSDK.xcframework.zip

Sources/ApMobileSDK.xcframework/ios-arm64/ApMobileSDK.framework/Headers/ApMobileSDK.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please verify if any additional imports are required in the header file.

ankushkumar5
ankushkumar5 reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ankushkumar5 ankushkumar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update readme and add documentation for implementation.

ankushkumar5
ankushkumar5 reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ankushkumar5 ankushkumar5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podspec and Package.swift doesn't have google ads SDK dependency. Please add it.

@ankushkumar5
Copy link
Contributor

Please Change:
:text => "Private license"
by
:file => "LICENSE"
in this line spec.license = { :type => "Proprietary", :text => "Private license" }
the purpose is to point to the correct LICENSE file

@ankushkumar5 ankushkumar5 merged commit 0c5b7ea into dev Jan 9, 2025
@ankushkumar5 ankushkumar5 deleted the feature branch January 9, 2025 05:30
ankushkumar5 added a commit that referenced this pull request Jan 9, 2025
@ankushkumar5 @rishh18
1.0.0 Release (#4)
8095db2 
* Create LICENSE

* initial commit (#1)

* initial commit

* Required Changes

* Final Changes

* Dependency Added

* Binary URL updated

* Readme Added (#3)

* Readme Added

* package file updated

* podspec change

* Readme changes

---------

Co-authored-by: rishh18 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushkumar5 ankushkumar5 ankushkumar5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishh18 @ankushkumar5