PoC for Keycloak 23.0.x support #952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Darimont <[email protected]>
- Keep backwards compatibility with Keycloak 18 / RH-SSO - add generated master realm for 23.0.0 - Adapted UserProfile handling to changes in Keycloak 23 - Adapted Groups handling due to changes in Keycloak 23 Needed to Adapt the ImportGroupsIT due to changes in serialization, instead of empty lists or maps, Keycloak now returns null. Fixes adorsys#948
thomasdarimont
force-pushed
the
update/keycloak-23.0.x
branch
from
a5131e8 to
c2e80b0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Note that we are also affected by this regression in Keyclaok 23.0.0 |
thomasdarimont
commented
Nov 29, 2023
| @@ -239,4 +238,12 @@ private GroupResource getResourceById(String realmName, String groupId) { | |||
| .groups() | |||
| .group(groupId); | |||
| } | |||
|
|
|||
| public List<GroupRepresentation> getSubGroups(String realmName, String parentGroupId) { | |||
| // TODO make max size configurable | |||
There was a problem hiding this comment.
Use subGroupCount from parent group as max
|
We are also affected by this: |
|
Closing in favor of the more complete solution: #958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Add Keycloak 23
Needed to Adapt the ImportGroupsIT due to changes in Keycloaks representations,
instead of empty lists or maps, Keycloak now returns null.
This is WIP other behaviour changed as well.
Currently 391 of 442 tests passes (50 failed tests)
Fixes #948
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR