Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customField "app" to JSON log messages #943

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

HenningWaack
Copy link
Contributor

Add the customField "app" with value "keycloak-config-cli" to each JSON log message. Fixes #942

What this PR does / why we need it:

In order to simplify finding logs from Keycloak Config CLI in a log aggregator like Kibana, it would be beneficial to mark every log entry with a custom field which identifies the CLI as its source.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #942

Add the customField "app" with value "keycloak-config-cli" to each JSON log message. Fixes adorsys#942
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #943 (8c58522) into main (cc36192) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #943      +/-   ##
============================================
- Coverage     95.53%   95.51%   -0.03%     
+ Complexity     1324     1323       -1     
============================================
  Files            78       78              
  Lines          4279     4279              
  Branches        477      477              
============================================
- Hits           4088     4087       -1     
  Misses           91       91              
- Partials        100      101       +1     

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonasvoelcker jonasvoelcker merged commit ef4683c into adorsys:main Jun 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom field "app=keycloak-config-cli" to JSON LogstashEncoder output
2 participants