Fix Unrecognized field "features" in ServerInfoRepresentation #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdarimont
force-pushed
the
issue/GH-927-Fix-unrecognized-field-in-serverinfo-response
branch
from
596e3d2 to
1ad292f
Compare
Codecov Report
@@ Coverage Diff @@
## main #928 +/- ##
=========================================
Coverage 95.53% 95.53%
Complexity 1322 1322
=========================================
Files 78 78
Lines 4273 4273
Branches 475 475
=========================================
Hits 4082 4082
Misses 91 91
Partials 100 100 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thomasdarimont
force-pushed
the
issue/GH-927-Fix-unrecognized-field-in-serverinfo-response
branch
from
1ad292f to
c598ecc
Compare
|
@st3v0rr I think this PR is ready and IMHO justifies a dedicated release. |
|
Thank you for this fix! I worked around this using |
thomasdarimont
force-pushed
the
issue/GH-927-Fix-unrecognized-field-in-serverinfo-response
branch
from
c598ecc to
a7cdd3b
Compare
|
@rene6502 Thanks, good catch! Just updated the PR. |
Update to Keycloak 22.0.4 to accommodate for "new" features field in server response. Using 22.0.4 also in CI ensures that this is also properly tested. Update default realm-export to 22.0.4. Fixes adorsys#927
thomasdarimont
force-pushed
the
issue/GH-927-Fix-unrecognized-field-in-serverinfo-response
branch
from
a7cdd3b to
5d8d785
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Keycloak 22.0.4 to accommodate for "new" features field in server response. Using 22.0.4 also in CI ensures that this is also properly tested.
What this PR does / why we need it:
The ServerInfiResponse changed in Keycloak 22.0.4 and now includes a "features" field. Without this fix keycloak-config-cli cannot be used with Keycloak 22.0.4.
Which issue this PR fixes
Fixes #927
Special notes for your reviewer:
I think it is not necessary to regenerate the realm export files for 22.0.4.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PRI tested a keycloak-config-cli build locally with this fix and it worked with Keycloak 22.0.4.