Fix #907 (JSON logging broken) #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #915 +/- ##
=========================================
Coverage 95.53% 95.53%
Complexity 1322 1322
=========================================
Files 78 78
Lines 4273 4273
Branches 475 475
=========================================
Hits 4082 4082
Misses 91 91
Partials 100 100 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
| @TestPropertySource(properties = { | ||
| "spring.main.log-startup-info=true", | ||
| "spring.profiles.active=json-log", | ||
|
|
There was a problem hiding this comment.
Would you mind removing the empty line? :)
|
@kschubert thanks for your contribution, would you mind to squash your commits into one for this PR? |
- JSON logging requires jakarta.xml.bind-api - logstash version 7.4 requires logback > 1.2, but Spring requires logback 1.2 - logstash needs to be lowered to version 7.2 (last version that is compatible to logback 1.2)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #907: add missing dependency jakarta.xml.bind-api; lower logstash version from 7.4 to 7.2 - 7.2 is the last version supporting logback 1.2, which is required by Spring and other components