Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sonar findings #699

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix sonar findings #699

merged 1 commit into from
Apr 8, 2022

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Apr 8, 2022

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #699 (1446b9f) into main (eae37db) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #699      +/-   ##
============================================
- Coverage     96.38%   96.36%   -0.03%     
+ Complexity     1288     1287       -1     
============================================
  Files            74       74              
  Lines          4121     4122       +1     
  Branches        454      454              
============================================
  Hits           3972     3972              
  Misses           64       64              
- Partials         85       86       +1     
Impacted Files Coverage Δ
...rvice/clientauthorization/PermissionTypeAndId.java 80.64% <ø> (ø)
...sys/keycloak/config/service/UserImportService.java 100.00% <100.00%> (ø)
...s/keycloak/config/service/ClientImportService.java 96.87% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae37db...1446b9f. Read the comment docs.

@jkroepke jkroepke merged commit 736e256 into main Apr 8, 2022
@jkroepke jkroepke deleted the sonar-fixes branch April 8, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant