Alias docker tags without Keycloak minor/patch version #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jonasvoelcker
approved these changes
Jun 25, 2024
|
Hi @daniel-shuy, after some releases due to a broken plugin we are now certain that all tags get created as desired, thanks a lot :) https://hub.docker.com/r/adorsys/keycloak-config-cli/tags?name=6.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the format of Docker tags is
<keycloak-config-cli version>-<keycloak library version>, e.g.6.0.2-22.0.4. Since the Keycloak library is backwards compatible to within the same major version, usually thekeycloak-config-cliuser will want to use the latest minor/patch version of the Keycloak library, without having to manually update the image tag everytime there is a new release.For each release, in addition to the existing Docker tags (
x.x.x-x.x.x), the updated Actions workflow also tags the Docker image with the formatx.x.x-x(e.g.6.0.2-22,latest-22).Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #808Special notes for your reviewer:
This was originally addressed in #850, but didn't work due to a typo. This PR contains the fix, as well as some improvements.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR