Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forward client javascript component #3

Merged
merged 36 commits into from
Nov 21, 2024
Merged

forward client javascript component #3

merged 36 commits into from
Nov 21, 2024

Conversation

chendiblessing
Copy link
Collaborator

No description provided.

@chendiblessing chendiblessing self-assigned this Oct 31, 2024
@chendiblessing chendiblessing removed the request for review from Blindspot22 November 11, 2024 08:22
Christiantyemele
Christiantyemele requested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@Christiantyemele Christiantyemele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo all the changes in the did-resolver-lib

@chendiblessing chendiblessing linked an issue Nov 11, 2024 that may be closed by this pull request
Create a didcomm forward client javascript client component. adorsys/didcomm-mediator-rs#209
Closed
Christiantyemele
Christiantyemele requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@Christiantyemele Christiantyemele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go through the reviews and adjust them to in your issue they are repeating in all the clients

Christiantyemele
Christiantyemele requested changes Nov 14, 2024
View reviewed changes
libs/message-handler/src/protocols/forward-client.ts Outdated Show resolved Hide resolved
libs/message-handler/src/app.tsx Outdated Show resolved Hide resolved
libs/message-handler/tsconfig.app.json Outdated Show resolved Hide resolved
libs/message-handler/tsconfig.node.json Outdated Show resolved Hide resolved
@chendiblessing chendiblessing requested review from Hermann-Core and removed request for IngridPuppet November 18, 2024 07:03
@chendiblessing chendiblessing merged commit c8b5ba5 into main Nov 21, 2024
2 checks passed
@chendiblessing chendiblessing deleted the 209-implement-forwardprotocol-for-javasript-client branch November 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tekum-Emmanuella Tekum-Emmanuella Tekum-Emmanuella approved these changes

@Christiantyemele Christiantyemele Christiantyemele approved these changes

@Hermann-Core Hermann-Core Hermann-Core approved these changes

Assignees

@chendiblessing chendiblessing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a didcomm forward client javascript client component.
4 participants
@chendiblessing @Hermann-Core @Christiantyemele @Tekum-Emmanuella