Fix macosx runpath dynamic library issue freetype lib (jdk10 and amber) #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable as different versions of Java call jre image folder name with a different name
…f not break the build or warn the user about it and continue the process
…to colour-codes.sh where it actually belongs
…nt lib for the JDK image folder for JDK8
… folder for all JDKs 10 and onwards
… failed previously, should work fine now
…NT_LIB_FOR_JDK_FLAG and COPY_MACOSX_FREE_FONT_LIB_FOR_JRE_FLAG
…NT_LIB_FOR_JDK_FLAG and COPY_MACOSX_FREE_FONT_LIB_FOR_JRE_FLAG
…or all JDK versions after JDK9, and also specific settings for JDK9
…reetype-lib # Conflicts: # makejdk-any-platform.sh
…rform MACOSX_FREE_FONT_LIB copying but jdk9 is allowed to do that
neomatrix369
added
bug
|
Running tests by kicking off the following jobs:
Please let me know if any other builds need running @smlambert Can I please request testing of JDK10 and/or amber builds using your testsuite for MacOSX libfreefont fixes. |
|
Applied config changes: to Jenkins build job for JDK 10 and Amber for MacOSX, this fixed the above issue, see build logs at https://ci.adoptopenjdk.net/view/work%20in%20progress/job/openjdk10_build_x86-64_macos/93/console (:heavy_check_mark:). Applied similar config for JDK9 for MacOSX: See build logs
We can choose to close the PR and apply config changes now onwards or merge the PR if you like - whichever works. |
gdams
approved these changes
Apr 1, 2018
|
@neomatrix369 please revert the jobs to using the correct config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up after fixes applied via #216 and #225. Issue reported on slack.
Macosx builds not impacted:
Note: docker builds are not impacted by this change
Failing macosx builds:
This worked fine previously see logs, snippet from JDK10 build logs:
Explicitly allowing the copying of libfreefont for JDK and JRE (setting to false) for all JDK versions (amber and JDK10 onwards).
Also explicitly setting copying libfreefont for JDK and JRE (setting to true) for JDK 9.