Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codesign not jdk13 #1565

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Codesign not jdk13 #1565

merged 2 commits into from
Mar 6, 2020

Conversation

sxa
Copy link
Member

@sxa sxa commented Feb 25, 2020

I want to clean up the "Failing Builds" tab - for this I need to run another successful build for the JDK13 ones that are failing. At the moment this is not possibly because it tries to force the codesigning option in which is not supported on JDK13.

Ref: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk13u/job/jdk13u-mac-x64-openj9/176/console

Using autoconf at /usr/local/bin/autoconf [autoconf (GNU Autoconf) 2.69]
configure: error: unrecognized options: --with-macosx-codesign-identity
configure exiting with result code 1

@sxa sxa added the bug Issues that are problems in the code as reported by the community label Feb 25, 2020
@sxa sxa added this to the February 2020 milestone Feb 25, 2020
@sxa sxa self-assigned this Feb 25, 2020
@sxa sxa modified the milestones: February 2020, March 2020 Mar 3, 2020
karianna
karianna approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 79c622e into adoptium:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

Assignees

@sxa sxa

Labels
bug Issues that are problems in the code as reported by the community
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@sxa @karianna @sxa555