Update build scripts with location of libfreetype.6.dylib #202

smlambert · 2018-01-05T13:35:06Z

There are MANY test failures due to missing the library libfreetype.6.dylib, as described here:
adoptium/aqa-tests#136 (comment)

Build scripts (like https://github.com/AdoptOpenJDK/openjdk-build/blob/master/makejdk.sh, makejdk-any-platform.sh, sbin/common-functions.sh) will need to be updated to refer to the actual location of this file.

The scripts are referring to the location "/Users/jenkins/workspace/openjdk_build_x86-64_macos/openjdk/installedfreetype/lib" for libfreetype.6.dylib. They should refer to jre/lib for libfreetype.6.dylib.

mbvreddy · 2018-01-29T17:17:21Z

I've looked into this issue and found that libfreetype.6.dylib is not a run-path dependent library. As a result libfontmanager.dylib is linked with the complete install_name of library.

Bhaktavatsals-MacBook-Pro:sdk mbvreddy$ otool -L /Users/mbvreddy/workarea/JDK/OPENJ9/jdk-9+181/lib/libfontmanager.dylib 
/Users/mbvreddy/workarea/JDK/OPENJ9/jdk-9+181/lib/libfontmanager.dylib:
	@rpath/libfontmanager.dylib (compatibility version 1.0.0, current version 1.0.0)
	/Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/installedfreetype/lib/libfreetype.6.dylib (compatibility version 12.0.0, current version 12.0.0)
	@rpath/libawt.dylib (compatibility version 1.0.0, current version 1.0.0)
	@rpath/libjava.dylib (compatibility version 1.0.0, current version 1.0.0)
	@rpath/libjvm.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1213.0.0)
	/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 104.1.0)

All other libraries part of JDK are created as run-path dependent libraries. For example libawt.dylib, libjava.dylib ...

As libfreetype.6.dylib is generated outside JDK, it is necessary to change LINKER flag -install_name /Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/installedfreetype/lib/libfreetype.6.dylib

to

-install_name @rpath/libfreetype.6.dylib

mbvreddy · 2018-01-29T18:07:42Z

I tried to see if there is any configure option in freetype-2.4.0 to change install_name to @rpath. I could not find any. Alternatively, we can use following command to change install_name of libfreetype.6.dylib

install_name_tool -id @rpath/libfreetype.6.dylib /Users/jenkins/workspace/openjdk_build_x86-64_macos/openjdk/installedfreetype/lib/libfreetype.6.dylib

mbvreddy · 2018-01-30T06:11:05Z

libfreetype.dylib.6 present in jdk/lib is not valid library on Mac. Another change is required to copy it as libfreetype.6.dylib

neomatrix369 · 2018-02-01T20:34:23Z

@mbvreddy Thanks for doing the investigation wrt to this issue. I'll attempt to use your suggestions and get back asap.

neomatrix369 · 2018-02-01T20:50:17Z

@mbvreddy Can you please explain to me what you mean by this:

As libfreetype.6.dylib is generated outside JDK, it is necessary to change LINKER flag -install_name /Users/jenkins/workspace/openjdk9_build_x86-64_macos/openjdk/installedfreetype/lib/libfreetype.6.dylib

to

-install_name @rpath/libfreetype.6.dylib

To which app is the -install_name flag passed?

The below command:

install_name_tool -id @rpath/libfreetype.6.dylib /Users/jenkins/workspace/openjdk_build_x86-64_macos/openjdk/installedfreetype/lib/libfreetype.6.dylib

Does not give a feedback if it has worked or not, just returns to the prompt.

What command did you use to find the attached runpath to this dynamic library? As the path is embedded inside the binary itself.

Would be great to get answers to the above.

@mbvreddy

… path embedded into the binary, and release it from the runpath dependency - as per suggestion from @mbvreddy, do it only for MacOSX builds (hence check for "darwin") Potentially fixes issue adoptium#202

mbvreddy · 2018-02-02T05:18:06Z

install_name_tool doesn't give any output. But you can use otool -L <library> to verify if run-path is enabled or not. It should output something like @rpath/libfreetype.6.dylib

mbvreddy · 2018-02-02T05:19:42Z

There is another issue to take care as mentioned in #202 (comment)

mbvreddy · 2018-02-02T05:23:27Z

To which app is the -install_name flag passed?

inorder to change -install_name to use @rpath, we need to modify freetype makefile which doesn't seem to be feasible option here. So, I found that we could use install_name_tool to solve this issue after library is built.

neomatrix369 · 2018-02-06T11:23:47Z

@mbvreddy thanks for all the feedback, we have used them to apply them to arrive at our fix

smlambert · 2018-03-18T02:36:33Z

Closing as now listed in summary issue #346

rubin55 · 2018-09-24T11:59:23Z

This bug still exists in the currently available for download OpenJDK8_x64_Mac_jdk8u172-b11.tar.gz:

Part of stacktrace when attempting to load libfontmanager.dylib:

!ENTRY org.eclipse.ui 4 0 2018-09-24 13:39:28.488
!MESSAGE Unhandled event loop exception
!STACK 0
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.UnsatisfiedLinkError: /Library/Java/JavaVirtualMachines/1.8.0.jdk/Contents/Home/jre/lib/libfontmanager.dylib: dlopen(/Library/Java/JavaVirtualMachines/1.8.0.jdk/Contents/Home/jre/lib/libfontmanager.dylib, 1): Library not loaded: @rpath/libfreetype.6.dylib
  Referenced from: /Library/Java/JavaVirtualMachines/1.8.0.jdk/Contents/Home/jre/lib/libfontmanager.dylib
  Reason: image not found)

Show Java version:

$ /Library/Java/JavaVirtualMachines/1.8.0.jdk/Contents/Home/bin/java -version
openjdk version "1.8.0-adoptopenjdk"
OpenJDK Runtime Environment (build 1.8.0-adoptopenjdk-jenkins_2018_05_19_02_01-b00)
OpenJDK 64-Bit Server VM (build 25.71-b00, mixed mode)

Show linker config for libfontmanager.dylib, linking to @rpath/libfreetype.6.dylib:

$ otool -L /Library/Java/JavaVirtualMachines/1.8.0.jdk/Contents/Home/jre/lib/libfontmanager.dylib
/Library/Java/JavaVirtualMachines/1.8.0.jdk/Contents/Home/jre/lib/libfontmanager.dylib:
	@rpath/libfontmanager.dylib (compatibility version 1.0.0, current version 1.0.0)
	@rpath/libfreetype.6.dylib (compatibility version 12.0.0, current version 12.0.0)
	@rpath/libawt.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 169.3.0)
	/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 56.0.0)
	@rpath/libjava.dylib (compatibility version 1.0.0, current version 1.0.0)
	@rpath/libjvm.dylib (compatibility version 1.0.0, current version 1.0.0)

Show included libfreetype filename to be erroneously named as libfreetype.dylib.6

$ find /Library/Java/ -type f -name *libfreetype*
/Library/Java//JavaVirtualMachines/1.8.0.jdk/Contents/Home/jre/lib/libfreetype.dylib.6

karianna · 2018-09-24T13:04:48Z

@rubin55 Yes, those binaries were produced under the old build scripts. Are you able to try a nightly build:

https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u-2018-09-24-11-44/OpenJDK8U_x64_mac_hotspot_2018-09-24-11-44.tar.gz

rubin55 · 2018-09-25T10:11:52Z

Hi @karianna , mmm still seems to be an issue there:

$ tar tvzf OpenJDK8U_x64_mac_hotspot_2018-09-24-11-44.tar.gz | grep -i freetype
-rwxr-xr-x  0 jenkins staff   696128 Sep 23 09:03 ./jdk8u181-b13/jre/lib/libfreetype.dylib.6

karianna · 2018-09-25T10:25:00Z

OK thank you.

ksilz · 2018-11-30T09:38:55Z

Hi @karianna, as of Nov 30, this is a still a problem with the nightly build for Mac OS:

$ tar tvzf OpenJDK8U-jdk_x64_mac_openj9_2018-11-29-11-20.tar | grep -i freetype
-rwxr-xr-x  0 jenkins staff   872912 29 Nov 09:48 jdk8u192-b12/Contents/Home/jre/lib/libfreetype.dylib.6

gdams · 2019-01-11T15:50:18Z

Coretto had the same issue as us: corretto/corretto-8#6

eed3si9n · 2019-01-11T18:31:44Z

Could someone provide a summary of what's going on with this bug, especially for JDK 8 please?
We thought previous PR #225 fixed it but it didn't, or the PR did resolve the issue for JDK 11, but not for JDK 8? Is there anyone working on this, if not are there something community can help? Thanks.

karianna · 2019-01-15T18:39:12Z

@eed3si9n @ksilz @rubin55 @smlambert

Can you try the JDK/JRE at: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-hotspot/148/

eed3si9n · 2019-01-15T19:08:32Z

@karianna I see libfreetype.6.dylib and libfreetype.dylib.6 under Contents/Home/jre/lib with slightly different file size:

-rwxr-xr-x@  1 xxx  staff    873072 Jan 15 12:38 libfreetype.6.dylib*
-rwxr-xr-x@  1 xxx  staff    873088 Jan 15 12:38 libfreetype.dylib.6*

Does that make sense?

karianna · 2019-01-16T09:53:33Z

@karianna I see libfreetype.6.dylib and libfreetype.dylib.6 under Contents/Home/jre/lib with slightly different file size:
-rwxr-xr-x@  1 xxx  staff    873072 Jan 15 12:38 libfreetype.6.dylib*
-rwxr-xr-x@  1 xxx  staff    873088 Jan 15 12:38 libfreetype.dylib.6*
Does that make sense?

@johnoliver Is there a reasonable explanation for that? I'd have thought a copy should mean == bytes.

ksilz · 2019-01-21T13:59:04Z

Latest nightly build OpenJDK8U-jdk_x64_mac_openj9_2019-01-21-09-29.tar.gz still shows two different files with different sizes. I think there should be only libfreetype.6.dylib:

lib  $ ls -al *freetype*
-rwxr-xr-x  1 karsten  staff  872896 21 Jan 10:24 libfreetype.6.dylib
-rwxr-xr-x  1 karsten  staff  872912 21 Jan 10:24 libfreetype.dylib.6

johnoliver · 2019-01-21T15:40:23Z

I believe the difference in size was introduced during signing

karianna added the bug Issues that are problems in the code as reported by the community label Jan 5, 2018

karianna added this to the 1.0.0 milestone Jan 5, 2018

karianna added the help wanted Issues that need an extra hand helping out with them label Jan 5, 2018

akolarkunnu mentioned this issue Jan 15, 2018

Mac ： jdk_sound ：javax/sound/midi/Devices/InitializationHang.java failed with Execution failed: `main' threw exception: java.lang.UnsatisfiedLinkError adoptium/aqa-tests#136

Closed

sxa added the macos Issues that affect or relate to the MAC OS label Jan 23, 2018

neomatrix369 mentioned this issue Feb 1, 2018

Fix macosx runpath dynamic library issue freetype lib #216

Merged

neomatrix369 mentioned this issue Feb 17, 2018

Fix macosx runpath dynamic library issue freetype lib - JDK8 #225

Merged

smlambert mentioned this issue Mar 18, 2018

Test failures related to Infra or Build Issues adoptium/aqa-tests#346

Closed

11 tasks

smlambert closed this as completed Mar 18, 2018

smlambert mentioned this issue Jun 14, 2018

freetype cannot be copied in JDK8+JDK9 builds on macos #354

Closed

karianna reopened this Sep 25, 2018

karianna assigned johnoliver Sep 25, 2018

karianna modified the milestones: 1.0.0, 2.0.0, 2.x.x Sep 29, 2018

karianna mentioned this issue Nov 6, 2018

AdoptOpenJDK 8 libfontmanager.dylib requires libfreetype.6.dylib AdoptOpenJDK/homebrew-openjdk#42

Closed

bturner mentioned this issue Nov 14, 2018

libfreetype.dylib is incorrectly packaged corretto/corretto-8#6

Closed

karianna modified the milestones: 2.x.x, December 2018 Dec 10, 2018

noelwelsh mentioned this issue Jan 7, 2019

Recommend AdoptOpenJDK OpenJDK 8 + HotSpot creativescala/creative-scala#58

Closed

karianna closed this as completed Jan 21, 2019

smlambert mentioned this issue Apr 16, 2019

libfreetype causes link issue (segfault+UnsatisfiedLinkError) for SWT (Eclipse IDE) on Fedora 28 #390

Closed

marschall mentioned this issue May 22, 2019

OpenJDK 8u212 and 11.0.3 image quality concerns docker-library/openjdk#320

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update build scripts with location of libfreetype.6.dylib #202

Update build scripts with location of libfreetype.6.dylib #202

smlambert commented Jan 5, 2018 •

edited

Loading

mbvreddy commented Jan 29, 2018

mbvreddy commented Jan 29, 2018

mbvreddy commented Jan 30, 2018

neomatrix369 commented Feb 1, 2018 •

edited

Loading

neomatrix369 commented Feb 1, 2018 •

edited

Loading

mbvreddy commented Feb 2, 2018

mbvreddy commented Feb 2, 2018

mbvreddy commented Feb 2, 2018 •

edited

Loading

neomatrix369 commented Feb 6, 2018

smlambert commented Mar 18, 2018

rubin55 commented Sep 24, 2018

karianna commented Sep 24, 2018 •

edited

Loading

rubin55 commented Sep 25, 2018

karianna commented Sep 25, 2018

ksilz commented Nov 30, 2018

gdams commented Jan 11, 2019

eed3si9n commented Jan 11, 2019

karianna commented Jan 15, 2019

eed3si9n commented Jan 15, 2019

karianna commented Jan 16, 2019

ksilz commented Jan 21, 2019

johnoliver commented Jan 21, 2019

Update build scripts with location of libfreetype.6.dylib #202

Update build scripts with location of libfreetype.6.dylib #202

Comments

smlambert commented Jan 5, 2018 • edited Loading

mbvreddy commented Jan 29, 2018

mbvreddy commented Jan 29, 2018

mbvreddy commented Jan 30, 2018

neomatrix369 commented Feb 1, 2018 • edited Loading

neomatrix369 commented Feb 1, 2018 • edited Loading

mbvreddy commented Feb 2, 2018

mbvreddy commented Feb 2, 2018

mbvreddy commented Feb 2, 2018 • edited Loading

neomatrix369 commented Feb 6, 2018

smlambert commented Mar 18, 2018

rubin55 commented Sep 24, 2018

karianna commented Sep 24, 2018 • edited Loading

rubin55 commented Sep 25, 2018

karianna commented Sep 25, 2018

ksilz commented Nov 30, 2018

gdams commented Jan 11, 2019

eed3si9n commented Jan 11, 2019

karianna commented Jan 15, 2019

eed3si9n commented Jan 15, 2019

karianna commented Jan 16, 2019

ksilz commented Jan 21, 2019

johnoliver commented Jan 21, 2019

smlambert commented Jan 5, 2018 •

edited

Loading

neomatrix369 commented Feb 1, 2018 •

edited

Loading

neomatrix369 commented Feb 1, 2018 •

edited

Loading

mbvreddy commented Feb 2, 2018 •

edited

Loading

karianna commented Sep 24, 2018 •

edited

Loading