Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK version used by WiX installer to one that we install with VS2022 #1063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sxa
Copy link
Member

@sxa sxa commented Nov 29, 2024

The 10.0.17763.0 is not installed on machines where we install VS2022 from Build Tools. It is assumed that it was installed via some of the earlier VS version roles in our playbooks. This PR updates the version used by the WiX installer so that it will currently run on machines which have only had the VS2022 compiler (the one used by all of the Temurin builds now).

Without this fix it fails when trying to do some locale related activities. Found as part of adoptium/infrastructure#3286 (comment)

Building setup translation for culture "de-de" with LangID "1031"...
Input Error: Can not find script file "C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\WiLangId.vbs".
WiLangId failed with : 1
Failed to generate setup translation of culture "de-de" with LangID "1031".
failed to build translation de-de 1031

This fix has been tested and the installer job runs to completion successfully. If desired for testing, a JDK24 JRE artifact created with this can be located at https://ci.adoptium.net/job/build-scripts/job/release/job/create_installer_windows_22621/4/artifact/wix/ReleaseDir/OpenJDK-jre_x64_windows_hotspot_24_26-ea.msi and should be equivalent to the one from the main pipelines at https://ci.adoptium.net/job/build-scripts/job/release/job/create_installer_windows/1127/artifact/wix/ReleaseDir/OpenJDK-jre_x64_windows_hotspot_24_26-ea.msi

@sxa sxa self-assigned this Nov 29, 2024
@sxa
Copy link
Member Author

sxa commented Nov 29, 2024

@adamfarley has confirmed that the two installers referenced above appear to be working the same, so I think this PR should be good.

Given the error message we got above it might be worth someone checking that it still works in one of the other languages (@hendrikebbers if you have a minute and are willing to test the first MSI link above to make sure it works in your default language that might be helpful) but I expect the risk to be low here so I'd be ok with putting this in without that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants