-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aixPb: Put /usr/bin in front of PATH #3716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is /etc
in there? I can't think of anything we need in the PATH that would be in there
Not sure. I'll remove it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also bear in mind that while this will be ok for new machines it likely won't change the existing machines which have PATH=/opt/freeware/bin
at the start as most machines currently won't match this regex, so if we don't put another case in here for that we'll need to look at patching the existing machines up (as described in #2288 (comment)). Also noting that this regex to update the config will trigger on every playbook execution since it sets the path to something that has PATH=/usr/bin
at the start. Something like @aixtools' proposal in #2288 (review) may be preferable, but I'm also ok with a one-off manual fixup.
holding off merging until we raise any appropriate work items here for consistency. |
I've manually updated the PATH on the current machines to start with |
To escape the rebase hell that is #2288, ive simply created a new pr :)