Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move CRB packages out of common build tool list #1743

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

sej-jackson
Copy link
Contributor

Signed-off-by: Sej [email protected]

The libdwarf-devel and libmpc-devel packages are no longer in the base repos for RedHat 8, and have been moved to the CodeReady Linux Builder (CRB) repository which is restricted access.

Moving these packages to the Additional_Build_Tools_NOT_RHEL8 list ensures that they are still installed on earlier versions of RedHat.

Copy link
Contributor

@Willsparker Willsparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; Ideally, we'd want to still have the packages for RHEL8, could we add a task to enable that repo? This webpage shows how, but I'm not entirely sure if we should be using subscription-manager in the playbooks. ping @sxa

@sxa
Copy link
Member

sxa commented Dec 9, 2020

Makes sense; Ideally, we'd want to still have the packages for RHEL8, could we add a task to enable that repo? This webpage shows how, but I'm not entirely sure if we should be using subscription-manager in the playbooks. ping @sxa

I'm ok with switching this off on RHEL8 for now (or perhaps we could check if CRB is enabled first?) but what's the option for CentOS8?

@Willsparker
Copy link
Contributor

what's the option for CentOS8?

That would be the PowerTools repository (See #1750 ). There's a link in the issue which suggests that repository can also be enabled for RHEL8, so we may not have to bother with CRB- if PowerTools contains libmpc-devel that is

@sej-jackson
Copy link
Contributor Author

@Willsparker I've now added the equivalent change for the CentOS.yml and updated the comment. No libmpc-devel for this one, and libdwarf-devel had already been added to "Additional_Build_Tools_NOT_CentOS8", but just not removed from "Build_Tool_Packages" which is why it still failed on CentOS8.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The VPC run at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=CentOS8,label=vagrant/963/console shows that the playbook went through but (as expected) the OpenJ9 buid failed when it tried to access the libdwarf headers so it shows with a yell warning symbol.

I've also kicked off https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=CentOS8,label=vagrant/964/console which will show a hotspot bulid run after the playbook, which should run clean since it shouldn't require libdwarf

@sxa sxa merged commit 66cbdda into adoptium:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants