-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move CRB packages out of common build tool list #1743
Conversation
Signed-off-by: Sej <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; Ideally, we'd want to still have the packages for RHEL8, could we add a task to enable that repo? This webpage shows how, but I'm not entirely sure if we should be using subscription-manager
in the playbooks. ping @sxa
I'm ok with switching this off on RHEL8 for now (or perhaps we could check if CRB is enabled first?) but what's the option for CentOS8? |
That would be the PowerTools repository (See #1750 ). There's a link in the issue which suggests that repository can also be enabled for RHEL8, so we may not have to bother with CRB- if PowerTools contains |
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/vars/RedHat.yml
Show resolved
Hide resolved
Signed-off-by: Sej <[email protected]>
@Willsparker I've now added the equivalent change for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - The VPC run at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=CentOS8,label=vagrant/963/console shows that the playbook went through but (as expected) the OpenJ9 buid failed when it tried to access the libdwarf
headers so it shows with a yell warning symbol.
I've also kicked off https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=CentOS8,label=vagrant/964/console which will show a hotspot bulid run after the playbook, which should run clean since it shouldn't require libdwarf
Signed-off-by: Sej [email protected]
The
libdwarf-devel
andlibmpc-devel
packages are no longer in the base repos for RedHat 8, and have been moved to the CodeReady Linux Builder (CRB) repository which is restricted access.Moving these packages to the
Additional_Build_Tools_NOT_RHEL8
list ensures that they are still installed on earlier versions of RedHat.