Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aixPB: Modify order of executition to have requirements first #1695

Merged
merged 6 commits into from
Dec 4, 2020
Merged

aixPB: Modify order of executition to have requirements first #1695

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c4cb38
aixPB: Modify order of so-called role executition to have requirement…
aixtools Nov 20, 2020
104de6a
aixPB: GNU software needed for some of the Ansible modules used in ot…
aixtools Nov 27, 2020
c17f9bd
aixPB: Remove spurious comments
aixtools Nov 27, 2020
d8b12c8
aixPB: Organize (and document/motivate) six groups of roles.
aixtools Dec 3, 2020
6252646
aixPB: Remove trailing space
aixtools Dec 4, 2020
a57c10b
aixPB: move X11 (AIX BOS) installation check to after OSS core instal…
aixtools Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions ansible/playbooks/AdoptOpenJDK_AIX_Playbook/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,35 @@
swap_size: 4096

roles:
- aixfs
- syslogs
# AIX base requirements
- X11
- openssl
# verify/install IBM compilers
- xlc_v13
- xlc_v16
- openssl
# AIX configuration
- aixfs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this moved to after the XLC/X11 installations? Wouldn't moving this cause problems if the file systems weren't large enough to install XLC/X11? I think that's why it was at the start previously.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is before xlc installation - it WAS after syslogs - which is a configuration change.

What I am trying to do is get AIX BOS installation first, then AIX configuration changes (that does not require any non-BOS software) and then start looking at licensed software.

As the xlc roles use, potentially, the unarchive: module - the latest update has the role: yum before the xlc role calls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it looks like it is after, but it is not. No idea how the diff comes up with this.

Further - as to large enough - installp enlarges the filesystem if more space is needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I am trying to do is get AIX BOS installation first, then AIX configuration changes (that does not require any non-BOS software) and then start looking at licensed software.

OK That reasoning is sound, but it might be worth explcitly saying that so that others modifying the file in the future adhere to the same policies

I agree, it looks like it is after, but it is not. No idea how the diff comes up with this.

Looks ok now - it's showing where it should be based on your comments

Further - as to large enough - installp enlarges the filesystem if more space is needed.

Yep that's fair, but I'd suggest adding that as a comment so it's clear to anyone modifying the playbook in the future

- syslogs

# yum based installation of additional software
- yum

# users needed - wait until here to be sure bash is installed
- jenkins_user
- zeus_user

# additional OSS packages (needing python)
- ant
- ant_contrib

# install/verify boot versions of ojdk
- bootjdk7
- bootjdk8
- bootjdk9
- bootjdk10
- bootjdk11
- bootjdk12

- ant
- ant_contrib

- jenkins_user
- zeus_user

tasks:
######################################
# Add bash to available login shells #
Expand Down