Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aix pb v2 #1583

Closed
wants to merge 8 commits into from
Closed

Aix pb v2 #1583

wants to merge 8 commits into from

Conversation

aixtools
Copy link
Contributor

@aixtools aixtools commented Oct 1, 2020

This is the development path of AIX Playbook Version 2 #1582

I am trying to give it a much better ansible look & feel - so comments from ansible experts re: structure is very very much appreciated.

@aixtools
Copy link
Contributor Author

aixtools commented Oct 1, 2020

FYI: the CI checks failing do not (all) seem to be related to this PR.

@karianna
Copy link
Contributor

karianna commented Oct 1, 2020

@aixtools Looks like the linter warnings are legitimate (for the coding stds the infra team has put on this repo). Maybe worth discussing on the Slack channel if you think those restrictions need changing.

@aixtools
Copy link
Contributor Author

aixtools commented Oct 1, 2020

Not saying they are not legitimate - but 'frustrating' if they are being caused by nothing "you" (that is me in third person) you have even looked at.

@Willsparker
Copy link
Contributor

Couple other yamlint errors:


./playbooks/aix/oss/tasks/main.yml
  3:1       error    too many blank lines (1 > 0)  (empty-lines)

./playbooks/aix/fs/tasks/main.yml
  3:1       error    too many blank lines (1 > 0)  (empty-lines)

./playbooks/aix/verify/tasks/main.yml
  3:1       error    too many blank lines (1 > 0)  (empty-lines)

./playbooks/aix/users/tasks/main.yml
  3:1       error    too many blank lines (1 > 0)  (empty-lines)

@aixtools
Copy link
Contributor Author

aixtools commented Oct 2, 2020

Closing this - to quiet the CI cycles - I shall continue to push to the PR and reopen (from time to time) to update current status.

@aixtools aixtools closed this Oct 2, 2020
@aixtools
Copy link
Contributor Author

aixtools commented Oct 8, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants