Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant dependent properties in test.properties files under external category #2972

Merged
merged 22 commits into from
Oct 16, 2021
Merged

Removed redundant dependent properties in test.properties files under external category #2972

merged 22 commits into from
Oct 16, 2021

Conversation

ManasviGoyal
Copy link
Contributor

fixes #2962

@ManasviGoyal ManasviGoyal marked this pull request as draft October 9, 2021 09:22
@ManasviGoyal ManasviGoyal marked this pull request as ready for review October 9, 2021 09:33
@ManasviGoyal
Copy link
Contributor Author

@ShelleyLambert @llxia please check and let me know if any changes are needes

@smlambert smlambert requested a review from sophia-guo October 9, 2021 13:45
sophia-guo
sophia-guo approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo
Copy link
Contributor

sophia-guo commented Oct 12, 2021 •
edited
Loading

This PR depends on the PR for #2964, which means it has to be merge with the PR for #2964.

smlambert
smlambert approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ManasviGoyal !

@smlambert smlambert merged commit 618f8f5 into adoptium:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@sophia-guo sophia-guo sophia-guo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove redundant dependent properties in test.properties files under external category
3 participants
@ManasviGoyal @sophia-guo @smlambert