Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regroup sanity according to openjdk tier1 #1695

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Mar 26, 2020

Regroup sanity according to openjdk tier1 and add missing tier1 group

Close #1691

Signed-off-by: Sophia Guo [email protected]

@karianna karianna added this to the March 2020 milestone Mar 26, 2020
@sophia-guo
Copy link
Contributor Author

Looks like for now there is no easy|quick solution to minus java/util/Arrays/TimSortStackSize2.java from jdk_util as a tier1_part2 from jdk11+. If we use problemlist to exclude it will not be executed in extended group, either.

Running java/util/Arrays/TimSortStackSize2.java in a grinder it doesn't take time at all ( 1 sec) and pass. So I will just keep it as part of jdk_util.

@sophia-guo
Copy link
Contributor Author

There is a new sub group jdk_foreign in tier1 from jdk14, which pass on Mac and fail on linux( only tried those two platforms for now as there is more interesting found). Failure case is java/foreign/TestArrays.java.TestArrays (TestNG tests). Interesting thing is when using customized target in grinder it consistently pass. Using jdk_foreign consistently failed on linux.

The difference is in customized target we are using the test directory to trigger the test and in jdk_foreign we are using the sub group name to trigger the test. By now I haven't noticed there is the difference using those two different way. If there is difference between those two ways I would say it is a jtreg bug. Note this test is testNG.

@sophia-guo
Copy link
Contributor Author

My grinders if anyone would like to take a deep look:
Grinder 1150 - 1132
https://ci.adoptopenjdk.net/view/work%20in%20progress/job/Grinder_Sandbox/1150/
...
https://ci.adoptopenjdk.net/view/work%20in%20progress/job/Grinder_Sandbox/1132/

@sophia-guo
Copy link
Contributor Author

Running jdk_foreign by group jdk_foreign locally in jenkins didn't hit any failures. Rerun by jenkins to see if the issue still happens.

@sophia-guo sophia-guo force-pushed the tier1 branch 2 times, most recently from c234016 to 2f524eb Compare March 30, 2020 15:33
@sophia-guo
Copy link
Contributor Author

sophia-guo commented Mar 30, 2020

Looks more than one testcase jdk_foreign has intermittent failures for both hotspot and openj9. Those tests are just added a few months ago. May not be stable? Will exclude them and open a new issue to track #1701

@sophia-guo sophia-guo changed the title WIP: Regroup sanity according to openjdk tier1 Regroup sanity according to openjdk tier1 Mar 30, 2020
@sophia-guo sophia-guo requested a review from smlambert March 30, 2020 15:59
@sophia-guo sophia-guo changed the title Regroup sanity according to openjdk tier1 WIP:Regroup sanity according to openjdk tier1 Mar 30, 2020
@sophia-guo sophia-guo changed the title WIP:Regroup sanity according to openjdk tier1 Regroup sanity according to openjdk tier1 Mar 30, 2020
Regroup sanity according to openjdk tier1 and add missing tier1 group
Exclude problematic testcases under jdk_foreign

Signed-off-by: Sophia Guo <[email protected]>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @sophia-guo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting openjdk sanity tests consistent with openjdk test group tier1
3 participants