fix: Ember is not defined error #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Rxbsxn
approved these changes
May 29, 2023
wozny1989
force-pushed
the
fix/wozny1989/ember-is-not-defined-error
branch
from
d501ce2 to
9fa3c11
Compare
mansona
requested changes
Jun 7, 2023
There was a problem hiding this comment.
So I don't think we should probably do these changes 🙈 I understand that you're trying to fix something here but I would rather a) just plainly remove the functionality b) fix it upstream or c) upgrade to more standard ways of doing it.
I hope all that makes sense?
wozny1989
force-pushed
the
fix/wozny1989/ember-is-not-defined-error
branch
from
9fa3c11 to
1a66927
Compare
wozny1989
force-pushed
the
fix/wozny1989/ember-is-not-defined-error
branch
from
1a66927 to
7bf19c0
Compare
|
@mansona You're right, I just removed functionality with register version if is no super required 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
Ember is not defined- import Ember during library version register