Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember-paper chip Click to add #587

Closed
bloodknight2010 opened this issue Dec 9, 2016 · 11 comments
Closed

Ember-paper chip Click to add #587

bloodknight2010 opened this issue Dec 9, 2016 · 11 comments
Labels

Comments

@bloodknight2010
Copy link

Hello All,

Chips with Autocomplete box does not work in chrome Version 50.0.2661.102 (64-bit)
Sometimes can't click to add custom data.

Thanks
photo

@v3ss0n
Copy link

v3ss0n commented Dec 12, 2016

Can be reproduced , that is working fine 1-2 weeks ago

@xomaczar
Copy link
Contributor

Can't reproduce in the latest e-p release

@v3ss0n
Copy link

v3ss0n commented Dec 14, 2016

Do you mean working on master?
Can still be reproduced on : http://miguelcobain.github.io/ember-paper/release-1/#/components/chips

steps:

  • Type what dosen't exist in (Chips With Autocomplete )
  • Click on "Not Found , Click to add"
  • Nothing happens

@xomaczar
Copy link
Contributor

Ohhh I thought not found rendered above

@v3ss0n
Copy link

v3ss0n commented Dec 17, 2016

is this related to #589 ?

@xomaczar
Copy link
Contributor

No not really.

pauln added a commit to pauln/ember-paper that referenced this issue Jan 30, 2017
…ed-ember-addons#587

Explicitly closing the autocomplete component on inputBlur broke the ability to add custom items to the chips element (assuming requireMatch is not true).  It doesn't appear to be necessary for any other purpose.
@Subtletree
Copy link
Collaborator

@pauln's fix tested and working for me : )

@v3ss0n
Copy link

v3ss0n commented Feb 1, 2017

thanks , so it fixed on @pauln 's fix ?

@saivarunr
Copy link

Unable to add custom chip on "Not found, click to add" hook on chrome 58.0.3029.81 (64-bit), works fine on mozilla.
Any idea why?

@pauln
Copy link
Contributor

pauln commented Apr 26, 2017

@saivarunr, the fix mentioned here still hasn't been merged - pull request #632 is still open. Once that gets merged, this should hopefully be fixed.

@miguelcobain, any idea when you might be able to look at merging this (and other chips-related PRs)?

@saivarunr
Copy link

@pauln thanks for swift reply, cool! Hope that will be fixed soon. cheers.

miguelcobain added a commit that referenced this issue Jul 26, 2017
Chips: Don't explicitly close autocomplete on inputBlur - fixes #587
vinilios pushed a commit to vinilios/ember-paper that referenced this issue Aug 28, 2019
…ed-ember-addons#587

Explicitly closing the autocomplete component on inputBlur broke the ability to add custom items to the chips element (assuming requireMatch is not true).  It doesn't appear to be necessary for any other purpose.
vinilios pushed a commit to vinilios/ember-paper that referenced this issue Aug 28, 2019
…ed-ember-addons#587

Explicitly closing the autocomplete component on inputBlur broke the ability to add custom items to the chips element (assuming requireMatch is not true).  It doesn't appear to be necessary for any other purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants