Remove babel transform plugin by default #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The babel transform that replaces the `variation` JS helper is problematic. It mostly works, however, detecting whether the helper is used inside a computed property is buggy and I'm yet to get it to a point that I feel is solid to be used by default in this addon. Also, this helper is essentially syntactic sugar and does feel like something that should be an "opt in". Therefore, this commit removes the babel transform from being added by default and, instead, gives users instructions on how they can include it in their app if they wish to use it. This is a breaking change.
patcoll
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The babel transform that replaces the
variationJS helper is problematic. It mostly works, however, detecting whether the helper is used inside a computed property is buggy and I'm yet to get it to a point that I feel is solid to be used by default in this addon.Also, this helper is essentially syntactic sugar and does feel like something that should be an "opt in".
Therefore, this commit removes the babel transform from being added by default and, instead, gives users instructions on how they can include it in their app if they wish to use it.
This is a breaking change.