Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @achambers, as a first step I upgraded the
ldclient-js
library to version 1.7.4, which is the one right before 2.0.0. I did this to bisect the rather large jump in version numbers, so that when the upgrade to 2.0.0 happens, we can rule out problems from any changes in the 1.x series.All tests pass. (Could we set up TravisCI or CircleCI for open source purposes to see CI results on GitHub?)
I don't have quick access to test this in a prod or even a test environment. Is it possible for you to try it out and see if there are any red flags?