-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adhoc: support deferred clientSideId and possibly secure mode? #27
adhoc: support deferred clientSideId and possibly secure mode? #27
Conversation
also an attempt at secure mode. Thus, one wouldn’t have to put the clientSideId into the config/environment.js The UI could hit an API endpoint, or possibly even the response body from a login, and then do something like this: return get(this, 'launchDarkly').initialize(userStuffHere, { clientSideId: FROM_THE_SERVER, hash: ALSO_FROM_THE_SERVER );
@rstudner We're doing a push to get this repo up to date and published as v1.0. Will get to this PR soon hopefully. You will see that Just wanted to reach out and let you know that this is not ignored or abandoned. I'll be in touch when we switch focus to this PR. |
@achambers how are things going on this effort? Anything we can help with? |
Hi @rwwagner90 👋 . Have not yet bumped the LD js client but I'm very keen to get to that soon. I'd not published I'll endeavour to do that tomorrow. As for this specific PR, I've not yet been able to cast my focus to it due to the above changes first. If you have interest in upgrading the LD client js, I'd love to accept a PR for that. Other than that, most of the things I wanted to get to have landed in |
@achambers thanks for the update! Is everything in master now? If so, I am happy to help try to update the LD client. |
@rwwagner90 said:
Confirm on As for the LD client, that'd be super ace if you were interested in running with it. It is severely behind. We recently updated it to the last version in the pre 1.x series. But I'd say bumping to the 2.x series might need some closer attention. I've skimmed the changelogs and I'm pretty sure there are one or two things there we care about. But it's been a while and have not given it deep thought yet. I'd be more than happy to act as a sounding board or help you out with this if you were willing to drive it. Let me know your thoughts on that. |
I can definitely take a look. I think it is on our radar to help out with this addon as part of our work, but not for at least a couple weeks probably. |
That'd be ace mate. Would be much appreciated. Would be great to have someone else who's using it in anger to bounce ideas off too.
No hassles. |
Hi @rwwagner90 . I've published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! This is now rebased and combines the documentation from #144. I think given the optionality we can merge and follow up if further support is required.
Thus, one wouldn’t have to put the clientSideId into the config/environment.js
The UI could hit an API endpoint, or possibly even the response body from a login, and then do something like this: