✨ Rearchitect for Octane and tracked properties #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achambers
force-pushed
the
based-on-tracked-properties
branch
from
862a846 to
7e034d5
Compare
Need to find the best way to test with acceptance tests, or indeed, if acceptance testing is the best level of testing. Until then, let's remove them.
achambers
force-pushed
the
based-on-tracked-properties
branch
from
7e034d5 to
c6067db
Compare
30 tasks
achambers
force-pushed
the
based-on-tracked-properties
branch
2 times, most recently
from
140761e to
5437ac4
Compare
|
Congrats @achambers ! |
Apologies it took so long. But this new world is soooo much simpler so I'm looking forward to being able to keep it up to date moving forward. Not sure if you're still using/invested in this addon but it'd be wonderful if you are in a position to trial the v2 beta and let me know if you run in to any issues. Just updating my production app so hoping to have have a good idea of how stable it is soon. |
|
Sadly, I've moved jobs and am no longer doing Ember. Maybe @k-dauda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a reimagining of the repo, implemented with glimmer tracking, specifically designed to work with Ember Octane and above.
Tracked properties allows us to remove a significant amount of complexity and to move to more natural Javascript patterns instead of Ember specific ones.
As a result, the intention is that this PR will form the basis for v2 of the addon that will support only Ember versions 3.17 and above.
From a high level this PR removes the concept of Ember services to keep track of the LD client and removes the initializers to instantiate them. It replaces them with simple functions that store and retrieve the client state from an object stored on
window, not unlike how something like@sentry/browseroperates.A nice addition to this new pattern is that the nicer API that the babel plugin gave us (a
variationimport) is now the exact way we import and use thevariationfunction. So, we were able to remove the babel plugin completely and just use JS.@tracked/Octane world? #201