Sync with @embroider/addon-blueprint #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
force-pushed
the
chore/sync-build-blueprint
branch
from
24b111f to
4b63c03
Compare
gilest
force-pushed
the
chore/sync-build-blueprint
branch
from
4b63c03 to
4e9da2c
Compare
Found this type to be incorrect when consuming with Glint in the test-app.
gilest
force-pushed
the
chore/sync-build-blueprint
branch
from
c3acda6 to
7378f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely dropping
rollup-plugin-tsand shipping adeclarationsdir along withdist. Should hopefully unblock the ability to ship Glint types.Apparently type declarations need to build into a separate directory so that rollup and glint don't mess with each other.
After this PR I may start actually updating directly from the blueprint.